graphiql@2

[thomasheyenbrock]

This branch collects all the breaking changes for the next major version of graphiql and will be merged once we're ready to release it.

For context, we decided on this approach because using changeset pre-releases would also block other packages from this repo (vscode-graphql etc.) from publishing non-prerelease versions (see here)

All the changes here have already been reviewed and approved individually:

• [redesign] editor in new design #2513
• [redesign] layout for editor components #2515
• [redesign] footer #2540
• [redesign] implement new toolbar design #2524
• [redesign] add spinner component to @graphiql/react #2539
• [redesign] implement sidebar #2543
• [redesign] implement new design for history plugin #2571
• [redesign] loading spinner #2581
• [redesign] move docs components to @graphiql/react #2582
• [redesign] implement new search combobox #2586
• [redesign] docs #2588
• [redesign] implement new design for tabs #2592
• [redesign] add settings dialog #2595
• [redesign] add dark mode #2596

[changeset-bot]

🦋 Changeset detected

Latest commit: 85218bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@graphiql/react	Minor
codemirror-graphql	Major
graphiql	Major
@graphiql/toolkit	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Merging #2523 (32566ab) into main (2d91916) will decrease coverage by 7.34%.
The diff coverage is 16.58%.

❗ Current head 32566ab differs from pull request most recent head 85218bd. Consider uploading reports for the commit 85218bd to get more accurate results

@@            Coverage Diff             @@
##             main    #2523      +/-   ##
==========================================
- Coverage   65.70%   58.36%   -7.35%     
==========================================
  Files          85       92       +7     
  Lines        5106     5313     +207     
  Branches     1631     1746     +115     
==========================================
- Hits         3355     3101     -254     
- Misses       1747     2191     +444     
- Partials        4       21      +17     

Impacted Files	Coverage Δ
packages/codemirror-graphql/src/lint.ts	100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts	47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts	95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts	0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts	79.48% <ø> (ø)
packages/graphiql-react/src/editor/completion.ts	0.00% <0.00%> (ø)
...hiql-react/src/editor/components/header-editor.tsx	0.00% <0.00%> (ø)
...phiql-react/src/editor/components/query-editor.tsx	0.00% <0.00%> (ø)
...hiql-react/src/editor/components/image-preview.tsx	2.56% <2.56%> (ø)
packages/codemirror-graphql/src/variables/lint.ts	47.61% <66.66%> (+0.63%)	⬆️
... and 145 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions]

The latest changes of this PR are available as canary in npm (based on the declared changesets):

[email protected]
[email protected]
@graphiql/[email protected]
@graphiql/[email protected]

[acao]

@thomasheyenbrock i had an idea for automating @next releases! This I think this will solve the problem completely.

in the canary script, we can just add conditional behavior for graphiql-v2 and non-forked branches with next/ branch, which skips the canary logic.

instead, it attempts a pre-release if a .changeset/pre.json is present. However in most cases when pushing commits, if the versions haven't been incremented since the last next release, nothing will happen.

so, when you're ready to publish another series of @next tags, just increment the versions where you need them and you're good to go! You may also want to increment in dependencies, though this can feel redundant with ^ resolution, it's more important when it's ready for a stable release to set a working baseline ofc.

for example, you won't need to make another codemirror-graphql pre-release again unless it changes, so you will be able to just push a commit that increments the next tag versions for graphiql and @graphiql/react and others as needed.

it's actually much simpler than the canary logic itself so it should be easier to implement.

[thomasheyenbrock]

@acao sounds like it should work. I'm just wondering how many next releases we actually need before having v2 ready, so not sure if it's worth the effort now. (At least for me who hasn't touched any of this canary logic it would take me some time to dig into it.)

For future major versions this would definitely be very nice to have!