generator.py: Restore pre-building gir with build/progress output
#1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit c6ba79e ("generator.py: Use cargo run instead of guessing path") the `cargo build` command on the default (hardcoded) `"gir"` directory was replaced with a single `cargo run` for correctly finding the right executable. This isn't an issue given that `cargo run` also builds the tool, and above all makes it easier / more correct to find the binary as the primary reason for that commit, but it does make us lose the build log as a progress indicator (thanks to `--quiet` and capturing `stderr`). In addition, it causes the first `` => Looking in path `xxx` `` item to take a very long time without aforementioned progres indication, making the user wonder what is going on. By building `gir` again with a separate `cargo build` invocation before running, this issue is alleviated somewhat.
|
@sophie-h What do you think? |
MarijnS95
commented
Nov 6, 2024
| @@ -7,7 +7,7 @@ | |||
| import asyncio | |||
|
|
|||
| DEFAULT_GIR_FILES_DIRECTORY = Path("./gir-files") | |||
| DEFAULT_GIR_DIRECTORY = Path("./gir/") | |||
| DEFAULT_GIR_DIRECTORY = Path("./gir/") # TODO: This is typically the directory _of this Python script_ (which external projects symlink to) | |||
There was a problem hiding this comment.
The TODO here means: should we come up with a different way, instead of "guessing/hardcoding" this relative directory?
|
@sophie-h what are your thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit c6ba79e ("generator.py: Use cargo run instead of guessing path") the
cargo buildcommand on the default (hardcoded)"gir"directory was replaced with a singlecargo runfor correctly finding the right executable.This isn't an issue given that
cargo runalso builds the tool, and above all makes it easier / more correct to find the binary as the primary reason for that commit, but it does make us lose the build log as a progress indicator (thanks to--quietand capturingstderr). In addition, it causes the first=> Looking in path `xxx`item to take a very long time without aforementioned progres indication, making the user wonder what is going on.By building
giragain with a separatecargo buildinvocation before running, this issue is alleviated somewhat.