Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generator.py: Restore pre-building gir with build/progress output #1613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

generator.py: Restore pre-building gir with build/progress output #1613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import asyncio

DEFAULT_GIR_FILES_DIRECTORY = Path("./gir-files")
DEFAULT_GIR_DIRECTORY = Path("./gir/")
DEFAULT_GIR_DIRECTORY = Path("./gir/") # TODO: This is typically the directory _of this Python script_ (which external projects symlink to)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO here means: should we come up with a different way, instead of "guessing/hardcoding" this relative directory?



def run_command(command, folder=None):
Expand Down Expand Up @@ -223,6 +223,9 @@ async def main():

if conf.gir_path is None:
update_submodule(DEFAULT_GIR_DIRECTORY, conf)
print("=> Building gir...")
run_command(["cargo", "build", "--release", "--manifest-path", DEFAULT_GIR_DIRECTORY / "Cargo.toml"])
print("<= Done!")

print("=> Regenerating crates...")
for path in conf.path:
Expand Down
Loading