gcpckms: add support for universe_domain and env handling #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Parse 'universe_domain' from config and env - Add WithUniverseDomain option and tests - Ensure tests read VAULT_GCPCKMS_UNIVERSE_DOMAIN Signed-off-by: Houssein Mnaouar <[email protected]>
This was referenced Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the universe_domain parameter in the gcpckms wrapper.
By default, gcpckms wrapper uses the standard
googleapis.comuniverse domain, but with this change, users can optionally configure a custom universe_domain to enable Vault to work in sovereign cloud environments.Related Issue
Closes #288
Changes Introduced
universe_domainfrom both config map and Env (VAULT_GCPCKMS_UNIVERSE_DOMAIN).Backward Compatibility
If
universe_domainis not set, Vault continues to usegoogleapis.comby defaultAdditional Context
This enhancement enables the use of Vault with GCP sovereign clouds, where custom API domains are required.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.