Skip to content

fix: quoting error in check-docs workflow #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix: quoting error in check-docs workflow #1450

merged 1 commit into from
Aug 7, 2024

Conversation

n-oden
Copy link
Contributor

@n-oden n-oden commented Aug 2, 2024 •
edited
Loading

Description

Backticks inside double-quotes will be treated as a shell escape.

Acceptance tests

n/a

Release Note

Release note for CHANGELOG:

NONE

References

See discussion in #1247

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@n-oden n-oden requested a review from a team as a code owner August 2, 2024 19:22
@n-oden n-oden mentioned this pull request Aug 2, 2024
Merged
1 task
@n-oden
Copy link
Contributor Author

n-oden commented Aug 5, 2024

@BBBmau here you go. :)

@n-oden
Copy link
Contributor Author

n-oden commented Aug 6, 2024

@BBBmau can you add the PR/no-changelog label? Since this is a fix to the test harness I wouldn't think a changelog entry is merited.

@n-oden
Copy link
Contributor Author

n-oden commented Aug 7, 2024

@BBBmau I think this is good to go; if we can get this merged I'll rebase #1247

@n-oden n-oden closed this Aug 7, 2024
@n-oden
fix: quoting error in check-docs workflow
7143477 
Backticks inside double-quotes will be treated as a shell escape.

Signed-off-by: Nathan J. Mehl <[email protected]>
@n-oden n-oden reopened this Aug 7, 2024
BBBmau
BBBmau approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

I'm including some more info around this failure for those that come across this PR in the future for a better understanding: https://www.linux.org/threads/backtick-usage.47910/

@BBBmau BBBmau merged commit 96996d9 into hashicorp:main Aug 7, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BBBmau BBBmau BBBmau approved these changes

Assignees
No one assigned
Labels
pr/no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-oden @BBBmau