Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-32201 release notes for product usage reporting #28904

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

VioletHynes
Copy link
Contributor

@VioletHynes VioletHynes commented Nov 13, 2024

Description

Companion PR for #28858 now that we're confident it's going in these three releases. It'll need to be backported together manually with that PR for 1.17 and 1.16. I'll do that once this is approved and merged etc.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@VioletHynes VioletHynes requested a review from a team as a code owner November 13, 2024 19:43
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 13, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@akshya96 akshya96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

| Known Issue (0.7.0+) | [Manual entity merges fail](/vault/docs/upgrading/upgrade-to-1.16.x#manual-entity-merges-sent-to-a-pr-secondary-cluster-are-not-persisted-to-storage) |
| Known Issue (1.16.7-1.16.8) | [Some values in the audit logs not hmac'd properly](/vault/docs/upgrading/upgrade-to-1.16.x#client-tokens-and-token-accessors-audited-in-plaintext) |
| New default (1.16.13) | [Vault product usage metrics reporting](/vault/docs/enterprise/license/product-usage-reporting) |
| Deprecation (1.16.13) | [`default_report_months` is deprecated for the `sys/internal/counters` API](/vault/docs/upgrading/upgrade-to-1.18.x#activity-log-changes) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the upgrade docs for 1.16, 1.17 as well? Asking because the link used here is for 1.18. Should we replace it with 1.16 link?

| Known Issue (1.17.3-1.17.4) | [Some values in the audit logs not hmac'd properly](/vault/docs/upgrading/upgrade-to-1.17.x#client-tokens-and-token-accessors-audited-in-plaintext) |
| Known Issue (1.17.0-1.17.5) | [Cached activation flags for secrets sync on follower nodes are not updated](/vault/docs/upgrading/upgrade-to-1.17.x#cached-activation-flags-for-secrets-sync-on-follower-nodes-are-not-updated) |
| New default (1.17.9) | [Vault product usage metrics reporting](/vault/docs/enterprise/license/product-usage-reporting) |
| Deprecation (1.17.9) | [`default_report_months` is deprecated for the `sys/internal/counters` API](/vault/docs/upgrading/upgrade-to-1.18.x#activity-log-changes) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the upgrade docs for 1.16, 1.17 as well? Asking because the link used here is for 1.18. Should we replace it with 1.17 link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's a good point -- it only applies in the latest releases but I think you're probably right. Let me make this update!

@akshya96 akshya96 self-requested a review November 14, 2024 17:59
@VioletHynes VioletHynes merged commit e309098 into main Nov 14, 2024
32 of 33 checks passed
@VioletHynes VioletHynes deleted the violethynes/VAULT-32201-upgrade-notes branch November 14, 2024 19:27
VioletHynes added a commit that referenced this pull request Nov 14, 2024
* VAULT-32201 release notes for product usage reporting

* Add note about default report months

* Better release notes
VioletHynes added a commit that referenced this pull request Nov 14, 2024
* VAULT-32201 release notes for product usage reporting

* Add note about default report months

* Better release notes
VioletHynes added a commit that referenced this pull request Nov 14, 2024
* VAULT-32201 release notes for product usage reporting

* Add note about default report months

* Better release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants