Downgrade NoLibraryFound from an error to a warning #9926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeofilC
force-pushed
the
wip/succeed-on-nothing-copy
branch
2 times, most recently
from
7980205
to
92ab485
Compare
Mikolaj
added
attention: needs-review
re: error-message
Mikolaj
approved these changes
Apr 24, 2024
geekosaur
approved these changes
Apr 24, 2024
TeofilC
force-pushed
the
wip/succeed-on-nothing-copy
branch
from
92ab485
to
94cee1f
Compare
|
I've added a test case of a package that is just a test suite. In fact this is one of the options offered by the |
TeofilC
force-pushed
the
wip/succeed-on-nothing-copy
branch
from
94cee1f
to
5fb3e36
Compare
alt-romes
approved these changes
Apr 30, 2024
TeofilC
force-pushed
the
wip/succeed-on-nothing-copy
branch
from
5fb3e36
to
6d9ea26
Compare
|
@TeofilC: could you kindly set a merge label, confirming you finished tweaking the PR, as per https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#github-pull-request-conventions? Thank you. |
|
Sounds good. Thanks! |
mergify
bot
added
the
merge delay passed
Mikolaj
force-pushed
the
wip/succeed-on-nothing-copy
branch
from
6d9ea26
to
c12f295
Compare
|
A very strange CI error out of a sudden: in https://github.com/haskell/cabal/actions/runs/8939442661/job/24555485188?pr=9926 Let me restart it. |
This makes Setup copy/install succeed if there's nothing to do because the package doesn't contain a library or executable. This allows downstream users of Cabal to avoid having to add workarounds for this edge case. Resolves #6750
Mikolaj
force-pushed
the
wip/succeed-on-nothing-copy
branch
from
c12f295
to
312a412
Compare
|
@mergify backport 3.12 |
✅ Backports have been created
|
5 tasks
mergify bot
added a commit
that referenced
this pull request
Jun 7, 2024
…10076) * Downgrade NoLibraryFound from an error to a warning This makes Setup copy/install succeed if there's nothing to do because the package doesn't contain a library or executable. This allows downstream users of Cabal to avoid having to add workarounds for this edge case. Resolves #6750 (cherry picked from commit 312a412) # Conflicts: # Cabal/src/Distribution/Simple/Install.hs * fixup! fix conflicts --------- Co-authored-by: Teo Camarasu <[email protected]> Co-authored-by: Artem Pelenitsyn <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Setup copy/install succeed if there's
nothing to do because the package doesn't contain
a library or executable.
This allows downstream users of Cabal to avoid having to add workarounds for this edge case.
Resolves #6750
Let me know what you think. If this sounds OK, I'll add a test case, which test suite would be best?