Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade NoLibraryFound from an error to a warning #9926

Merged
merged 1 commit into from
May 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Cabal/src/Distribution/Simple/Errors.hs
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ data CabalException
| EnableBenchMark
| BenchMarkNameDisabled String
| NoBenchMark String
| NoLibraryFound
| -- | @NoLibraryFound@ has been downgraded to a warning, and is therefore no longer emitted.
NoLibraryFound
| CompilerNotInstalled CompilerFlavor
| CantFindIncludeFile String
| UnsupportedTestSuite String
Expand Down
2 changes: 1 addition & 1 deletion Cabal/src/Distribution/Simple/Install.hs
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ install_setupHooks

checkHasLibsOrExes =
unless (hasLibs pkg_descr || hasForeignLibs pkg_descr || hasExes pkg_descr) $
dieWithException verbosity NoLibraryFound
warn verbosity "No executables and no library found. Nothing to do."

-- | Copy package global files.
copyPackage
Expand Down
15 changes: 15 additions & 0 deletions cabal-testsuite/PackageTests/OnlyTestSuite/OnlyTestSuite.cabal
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
cabal-version: 3.0
name: OnlyTestSuite
version: 0.1.0.0
build-type: Simple

common warnings
ghc-options: -Wall

test-suite OnlyTestSuite-test
import: warnings
default-language: Haskell2010
type: exitcode-stdio-1.0
hs-source-dirs: test
main-is: Main.hs
build-depends: base
6 changes: 6 additions & 0 deletions cabal-testsuite/PackageTests/OnlyTestSuite/cabal.cabal.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Setup configure
Configuring OnlyTestSuite-0.1.0.0...
# Setup build
Building OnlyTestSuite-0.1.0.0...
# Setup copy
Warning: No executables and no library found. Nothing to do.
6 changes: 6 additions & 0 deletions cabal-testsuite/PackageTests/OnlyTestSuite/cabal.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Setup configure
Configuring OnlyTestSuite-0.1.0.0...
# Setup build
Building OnlyTestSuite-0.1.0.0...
# Setup copy
Warning: No executables and no library found. Nothing to do.
6 changes: 6 additions & 0 deletions cabal-testsuite/PackageTests/OnlyTestSuite/cabal.test.hs
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import Test.Cabal.Prelude
main = setupAndCabalTest $ do
withPackageDb $ do
setup "configure" []
setup "build" []
setup "copy" []
4 changes: 4 additions & 0 deletions cabal-testsuite/PackageTests/OnlyTestSuite/test/Main.hs
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module Main (main) where

main :: IO ()
main = putStrLn "Test suite not yet implemented."
13 changes: 13 additions & 0 deletions changelog.d/issue-6750
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
synopsis: Make Setup copy/install succeed when there's no executable or library
packages: Cabal
prs: #9926
issues: #6750

description: {
Historically the Setup copy and install steps would fail if the package didn't
contain an executable or library component. In this case there's nothing to do.

This required workarounds for downstream users of Cabal to handle this edge case.
Now that this error has been downgraded to a warning, Cabal will succeed if
there's nothing to do.
}
Loading