-
Notifications
You must be signed in to change notification settings - Fork 365
Print mutation details on inlined code detection warning #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Print mutation details on inlined code detection warning #685
Conversation
9b8306a to
d572600
Compare
d572600 to
3ddf829
Compare
|
I updated this PR to latest |
8e2e43a to
9c35e4c
Compare
|
This will make the log even more noisy. There isn't really an action the user can take when this occurs (beyound raising an issue) so it was probably incorrect to make it a warning in the first place. If you can update it to be a debug message I'll merge it in. |
|
I don't fully remember as it is 3 years ago. Ok, that was a lie, the average developer ignores warnings, but don't destroy my dreams. :-D |
d5c0960 to
d1d6258
Compare
|
Yeah, it's still the same. with no way to see what might be the problem to at least be able to report it properly. |
d1d6258 to
093e47b
Compare
|
If you are concerned about the noise, how about adding the details only in |
a40d70c to
9650585
Compare
9650585 to
83b787e
Compare
83b787e to
fa0b629
Compare
fa0b629 to
d227701
Compare
No description provided.