Skip to content

Print mutation details on inlined code detection warning #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Print mutation details on inlined code detection warning #685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .../java/org/pitest/mutationtest/build/intercept/javafeatures/InlinedFinallyBlockFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import java.util.stream.Collectors;

import static java.util.function.Predicate.isEqual;
import static java.util.stream.Collectors.joining;
import static org.pitest.bytecode.analysis.InstructionMatchers.anyInstruction;
import static org.pitest.bytecode.analysis.InstructionMatchers.isInstruction;
import static org.pitest.bytecode.analysis.InstructionMatchers.notAnInstruction;
Expand Down Expand Up @@ -194,7 +195,12 @@ private boolean isInFinallyBlock(MutationDetails m) {

private boolean isPossibleToCorrectInlining(List<MutationDetails> mutationsInHandlerBlock) {
if (mutationsInHandlerBlock.size() > 1) {
LOG.warning("Found more than one mutation similar on same line in a finally block. Can't correct for inlining.");
LOG.warning("Found more than one mutation similar on same line in a finally block. "
+ "Can't correct for inlining.\n\t"
+ mutationsInHandlerBlock
.stream()
.map(Object::toString)
.collect(joining("\n\t")));
return false;
}

Expand Down