Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LANGUAGE] improve error message for unquoted string with comma #4786

Merged
merged 30 commits into from
Nov 24, 2023

Conversation

Felienne
Copy link
Member

@Felienne Felienne commented Nov 22, 2023

Fixes #3967

How to test

Check the error from #3967 is improved (I have also added tests)

@Felienne Felienne changed the title {LANGUAGEadd tests and extra error production [LANGUAGE] add tests and extra error production Nov 22, 2023
@Felienne Felienne changed the title [LANGUAGE] add tests and extra error production [LANGUAGE] improve error message for unquoted string with comma Nov 22, 2023
@Felienne Felienne requested a review from jpelay November 22, 2023 16:42
@ghost
Copy link

ghost commented Nov 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Felienne! I like that we are working on our error messages a bit!

I tested the PR, and it does indeed solve the issue, however, maybe we should account for this case too? It's a similar type of error, although, granted, the syntax highlighter already hints that this is not correct code by not coloring the string purple.

image

@Felienne
Copy link
Member Author

Hi Felienne! I like that we are working on our error messages a bit!

I tested the PR, and it does indeed solve the issue, however, maybe we should account for this case too? It's a similar type of error, although, granted, the syntax highlighter already hints that this is not correct code by not coloring the string purple.

image

Ah nice idea! Let me see if I can incorporate that into this PR!

@Felienne
Copy link
Member Author

Done!

@Felienne Felienne requested a review from jpelay November 24, 2023 08:46
Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

Copy link
Contributor

mergify bot commented Nov 24, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Nov 24, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4d983d5 into main Nov 24, 2023
11 checks passed
@mergify mergify bot deleted the comma-print branch November 24, 2023 23:26
Copy link
Contributor

mergify bot commented Nov 24, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

rix0rrr pushed a commit that referenced this pull request Nov 25, 2023
Fixes #3967


**How to test**

Check the error from  #3967 is improved (I have also added tests)
mergify bot pushed a commit that referenced this pull request Nov 30, 2023
I was adding tests to fix #4355 but it turned out the error is already fixed! (I suspect by #4786?)

So let's just add some tests.

**How to test**
The tests pass :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] confusing error message in level 4 for unmatched quotes
2 participants