Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid cross-test config contamination in microprofile/telemetry tests #9685

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Jan 24, 2025

Description

Resolves #9513

Intermittent test failures in micrometer/telemetry seem to be due to tests which need a full-featured OTel instance inheriting a default no-op one from other tests which run earlier which do not need a full OTel and in fact establish a no-op default one.

This PR segregates the test that does not enforce an active OTel from the others.

Documentation

No impact.

@tjquinno tjquinno self-assigned this Jan 24, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 24, 2025
@tjquinno tjquinno changed the title Avoid cross-test config contamination Avoid cross-test config contamination in microprofile/telemetry tests Jan 24, 2025
@tvallin
Copy link
Member

tvallin commented Jan 24, 2025

Can you please link your PR to this issue ? #9513
Thanks !

@tjquinno tjquinno merged commit aaaf65c into helidon-io:main Jan 24, 2025
58 checks passed
@tjquinno tjquinno deleted the 4.x-mp-telemetry-test-exec branch January 24, 2025 17:50
@tjquinno tjquinno mentioned this pull request Jan 21, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.x: TestTracerAtStartup#checkForFullFeaturedTracerAtStartup fails on Windows
3 participants