Helidon data Repository #9993

Tomas-Kraus · 2025-04-11T13:11:15Z

Helidon data introduction into Helidon v 4

API
Jakarta persistence based implementation of repository pattern
Transaction API
Data source API

API:

data/data
transaction/transaction

Implementation:

all modules under data except for codegen
all modules under transaction except for codegen

Codegen:

code generation modules

Tests that show usage:

data/tests/model - entities
data/tests/repository - API usage to create repositories
data/tests/common - test classes used from all test modules
data/tests/eclipselink/mysql - and other modules in the same directory - tests using direct JDBC connection, data sources, JTA etc.

ljnelson

I was requested to review this. I've left my comments just as comments so as not to block anything. Because the PR was three hundred and ninety three files, I restricted most of my comments to the public API areas and tended to skip things. In general everything is very underspecified. I'm sure it all works.

ljnelson · 2025-07-01T16:32:46Z

codegen/codegen/src/main/java/io/helidon/codegen/RoundContextImpl.java

+        // this is most likely a type that is generated,
+        // so there is a good chance it was generated before, let's try
+        // with package name(s) of the generated types
+        // default (empty) package should not be used by programs, so we can make this bold assumption


This seems worthy of a release note

@tomas-langer This is one of yours changesets, please have a look at this.

data/codegen/codegen/src/main/java/io/helidon/data/codegen/BaseQueryMethodsGenerator.java

data/codegen/codegen/src/main/java/io/helidon/data/codegen/DataCodegenTypes.java

data/codegen/common/src/main/java/io/helidon/data/codegen/common/MethodParamsBlueprint.java

data/sql/common/src/main/java/io/helidon/data/sql/common/SqlDriver.java

ljnelson · 2025-07-01T19:48:40Z

data/sql/datasource/datasource/src/main/java/io/helidon/data/sql/datasource/ProviderConfig.java

+// DataSourceProviderConfig
+
+/**
+ * Provider specific configuration.


What rules does this interface add to NamedService? If the answer is "none", why does this interface exist? If the answer is not "none", then describe them here.

@tomas-langer Those config blueprints is your concept.

When used, we want to only permit ProviderConfig instances, not any NamedService out there.

...sistence/codegen/src/main/java/io/helidon/data/jakarta/persistence/codegen/JpqlKeywords.java

...nce/src/main/java/io/helidon/data/jakarta/persistence/JpaPersistenceUnitConfigBlueprint.java

...rta-persistence/src/main/java/io/helidon/data/jakarta/persistence/JpaRepositoryExecutor.java

Signed-off-by: Tomáš Kraus <[email protected]>

…ing. Signed-off-by: Tomáš Kraus <[email protected]>

Signed-off-by: Tomáš Kraus <[email protected]>

- fix versions in bom pom - remove versions from all pom - remove gapi module - update entity provider codegen, remove Class.forName - renamed connection string in SqlConfigBlueprint to connection uri - added version management for commons-compress and related libraries - register JNDI in component using it Other updates: - added connection config blueprint used from providers and data sources - removed data source common module - changed the configuration structure to use `connection` for providers (not when using data source)

Signed-off-by: Tomáš Kraus <[email protected]>

Fix for Hikari provider service, to use the data source config create by teh data source config factory Fix to allow usage of Suite in MP (setting system property)

…TA transaction. Signed-off-by: Tomáš Kraus <[email protected]>

Signed-off-by: Tomáš Kraus <[email protected]>

* Refactored: - data, removed the data registry abstraction - sql data source testing - sql data source tests - added support for JDBC based data source (no pooling) * Eclipselink tests all fixed Hibernate work in progress * Update of all tests to work with the new approach. * Spotbugs exclude.

Signed-off-by: Tomáš Kraus <[email protected]>

…pport Signed-off-by: Tomáš Kraus <[email protected]>

Tomas-Kraus self-assigned this Apr 11, 2025

oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 11, 2025

Tomas-Kraus force-pushed the features/helidon-data branch 2 times, most recently from 6023a5d to 5f35edc Compare April 16, 2025 12:05

Tomas-Kraus force-pushed the features/helidon-data branch from 5f35edc to 51639bf Compare May 7, 2025 14:11

Tomas-Kraus force-pushed the features/helidon-data branch 2 times, most recently from defebbd to 18d7cf9 Compare May 20, 2025 12:11

Tomas-Kraus force-pushed the features/helidon-data branch 2 times, most recently from abb2524 to 546c88a Compare June 5, 2025 12:19

Tomas-Kraus changed the title ~~WIP: Verify merge of features/helidon-data into main~~ [WIP] Helidon data Repository Jun 10, 2025

tomas-langer requested review from tomas-langer, barchetta and romain-grecourt June 10, 2025 14:07

tomas-langer marked this pull request as ready for review June 10, 2025 14:07

tomas-langer added this to the 4.3.0 milestone Jun 10, 2025

tomas-langer added declarative Helidon Declarative data Helidon Data (SE feature) enhancement New feature or request dependencies Pull requests that update a dependency file labels Jun 10, 2025

Tomas-Kraus force-pushed the features/helidon-data branch from de9d83e to 3ab7417 Compare June 11, 2025 13:10

Tomas-Kraus changed the title ~~[WIP] Helidon data Repository~~ Helidon data Repository Jun 11, 2025

ljnelson reviewed Jul 1, 2025

View reviewed changes

Tomas-Kraus mentioned this pull request Jul 15, 2025

Helidon Data: Fix Sort/Order issues in the javadoc #10384

Open

Tomas-Kraus force-pushed the features/helidon-data branch from b162057 to 5861309 Compare July 16, 2025 11:20

Tomas-Kraus and others added 6 commits July 17, 2025 14:31

Initial commit of Helidon Data.

cf333aa

Changes to fit into Helidon project, compile, copyright, and checkstyle.

09d09ae

Reformat and rearrange all code according to Helidon formatting rules.

2f6ab2a

Add missed files.

4f939ec

JNDI implementation on top of service registry.

8658c80

Fixed dependency issue with JNDI module

41896c4

Tomas-Kraus and others added 25 commits July 17, 2025 14:32

Fixed tests and renamed test modules and packages.

c15a049

Signed-off-by: Tomáš Kraus <[email protected]>

Jakarta Transaction support for annotated methods.

ed9ae0c

Signed-off-by: Tomáš Kraus <[email protected]>

Jakarta Transaction support for Tx.transaction static methods.

9ab5eab

Signed-off-by: Tomáš Kraus <[email protected]>

Jakarta Transaction support: code cleanup

262b44f

Signed-off-by: Tomáš Kraus <[email protected]>

TxSupport#type() changed to String.

a221877

Signed-off-by: Tomáš Kraus <[email protected]>

Resource local transactions in JPA before TransactionContext refactor…

4f8df3b

…ing. Signed-off-by: Tomáš Kraus <[email protected]>

Resource local transactions in JPA finished.

85aa8c6

Signed-off-by: Tomáš Kraus <[email protected]>

Code cleanup.

a1019f7

Signed-off-by: Tomáš Kraus <[email protected]>

Transaction API refactoring.

82070d8

Signed-off-by: Tomáš Kraus <[email protected]>

Removed deleted module from bom and all

fa9f0bc

Fixed failing test.

a1b7d9d

Signed-off-by: Tomáš Kraus <[email protected]>

Failing MP tests because of missing DataSource config.

293f14d

Signed-off-by: Tomáš Kraus <[email protected]>

Fix for data source config factory to use the correct root node

5da0eef

Fix for Hikari provider service, to use the data source config create by teh data source config factory Fix to allow usage of Suite in MP (setting system property)

Test Helidon Data and CDI JPA support modules to run under the same J…

6480d3f

…TA transaction. Signed-off-by: Tomáš Kraus <[email protected]>

Test Helidon Data and CDI JPA support modules to run under the same J…

c83cb7d

…TA transaction. Signed-off-by: Tomáš Kraus <[email protected]>

Fixed spotbugs issue.

6e1d6ca

Signed-off-by: Tomáš Kraus <[email protected]>

Update to configuration.

d4fb6a6

Update to configuration: integration tests config update.

fd6f078

Signed-off-by: Tomáš Kraus <[email protected]>

Helidon Data API cleanup.

7e8e72a

Signed-off-by: Tomáš Kraus <[email protected]>

Added TypeName constants tests in codegen modules.

3b7734c

Signed-off-by: Tomáš Kraus <[email protected]>

Version update after release.

22333e2

Signed-off-by: Tomáš Kraus <[email protected]>

Review notes applied.

5d34559

Signed-off-by: Tomáš Kraus <[email protected]>

Removed workaround after varargs in blueprints were fixed.

58cd5fa

Signed-off-by: Tomáš Kraus <[email protected]>

Tomas-Kraus force-pushed the features/helidon-data branch from 592fa41 to 1f5b94b Compare July 17, 2025 12:34

Tomas-Kraus added 3 commits July 18, 2025 16:42

Helidon data rewiew.

fa38ba3

Signed-off-by: Tomáš Kraus <[email protected]>

Fixed codegen for CrudRepository update methods.

7493a62

Signed-off-by: Tomáš Kraus <[email protected]>

Fixed codegen for dynamic ordering: added missing case sensitivity su…

0089bae

…pport Signed-off-by: Tomáš Kraus <[email protected]>

Tomas-Kraus force-pushed the features/helidon-data branch from 158cb93 to 0089bae Compare July 18, 2025 14:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Helidon data Repository #9993

Helidon data Repository #9993

Tomas-Kraus commented Apr 11, 2025 •

edited by tomas-langer

Loading

Uh oh!

ljnelson left a comment

Uh oh!

ljnelson Jul 1, 2025

Uh oh!

Tomas-Kraus Jul 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ljnelson Jul 1, 2025

Uh oh!

Tomas-Kraus Jul 17, 2025

Uh oh!

tomas-langer Jul 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Helidon data Repository #9993

Are you sure you want to change the base?

Helidon data Repository #9993

Conversation

Tomas-Kraus commented Apr 11, 2025 • edited by tomas-langer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljnelson left a comment

Choose a reason for hiding this comment

Uh oh!

ljnelson Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Tomas-Kraus Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ljnelson Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Tomas-Kraus Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

tomas-langer Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Tomas-Kraus commented Apr 11, 2025 •

edited by tomas-langer

Loading

Tomas-Kraus Jul 15, 2025 •

edited

Loading