Fix overly-aggressive deduplicator #1409
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a pretty major bug in Herbie, noted in #1372: Herbie has recently turned terrible at rewrites. I figured out why; it's the deduplicator. Basically, suppose we have a batch with both the expressions
e1 = 1ande2 = (1 + x) - xin it. (In facte1is a subexpression ofe2.) Ok, well, we will prove thate2 = e1in the rewriter. So we will construct the alt historiese1 -> e1and alsoe2 -> e1. However, unfortunately, we then deduplicate by final expression, deleting the second (useful) alt and keeping only the first (dumb) one.This PR fixes it in a fairly ham-fisted way by deduplicating less, which might mean Herbie runs for longer. But it's surely worth it.