Remove and deprecate commons APIs #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
changed the title
schneems
changed the title
These structs were used with the old trait based API. They're not needed anymore as env-vars can be written without needing a struct now.
These were used in the style guide and docs for a deprecated feature.
schneems
force-pushed
the
schneems/rm-rf-deprecated-interfaces
branch
from
6188226
to
2e0b0c4
Compare
edmorley
approved these changes
Nov 10, 2024
schneems
force-pushed
the
schneems/rm-rf-deprecated-interfaces
branch
from
ee2da09
to
65782e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on these being merged first: