Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and deprecate commons APIs #345

Merged
merged 16 commits into from
Nov 11, 2024
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,19 +95,3 @@ jobs:
run: pack build my-image --force-color --builder heroku/builder:24 --trust-extra-buildpacks --buildpack heroku/nodejs-engine --buildpack packaged/${{ matrix.target }}/debug/heroku_ruby --path tmp/ruby-getting-started --pull-policy never
- name: "PRINT: Cached getting started guide output"
run: pack build my-image --force-color --builder heroku/builder:24 --trust-extra-buildpacks --buildpack heroku/nodejs-engine --buildpack packaged/${{ matrix.target }}/debug/heroku_ruby --path tmp/ruby-getting-started --pull-policy never

print-style-guide:
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Install musl-tools
run: sudo apt-get install musl-tools --no-install-recommends
- name: Update Rust toolchain
run: rustup update
- name: Install Rust linux-musl target
run: rustup target add x86_64-unknown-linux-musl
- name: Rust Cache
uses: Swatinem/[email protected]
- name: "PRINT: Style guide"
run: cargo run --quiet --bin print_style_guide
12 changes: 0 additions & 12 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions commons/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog for commons features

## 2024-10-30
schneems marked this conversation as resolved.
Show resolved Hide resolved

## Changed

- Deprecate `layers` including `layers::ConfigureEnvLayer` and `layers::DefaultEnvLayer` ()
- Remove `AppCacheCollection` ()
- Deprecate `output` module in favor of the `bullet_stream` crate ()

## 2024-08-16

### Fixed
Expand Down
6 changes: 0 additions & 6 deletions commons/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,16 @@ name = "commons"
edition.workspace = true
rust-version.workspace = true

[[bin]]
name = "print_style_guide"
path = "bin/print_style_guide.rs"

[lints]
workspace = true

[dependencies]
ascii_table = { version = "4", features = ["color_codes"] }
byte-unit = "5"
const_format = "0.2"
# TODO: Consolidate on either the regex crate or the fancy-regex crate, since this repo currently uses both.
fancy-regex = "0.13"
fs_extra = "1"
fs-err = "3"
fun_run = "0.2"
glob = "0.3"
indoc = "2"
lazy_static = "1"
Expand Down
216 changes: 0 additions & 216 deletions commons/bin/print_style_guide.rs

This file was deleted.

10 changes: 2 additions & 8 deletions commons/src/cache.rs
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
mod app_cache;
mod app_cache_collection;
mod clean;
mod config;
mod error;
mod in_app_dir_cache_layer;

pub use self::app_cache::{build, PathState};
pub use self::app_cache::{AppCache, CacheState};
#[allow(deprecated)]
pub use self::app_cache_collection::AppCacheCollection;
pub use self::app_cache::{build, AppCache, CacheState, PathState};
pub use self::clean::FilesWithSize;
pub use self::config::CacheConfig;
pub use self::config::{mib, KeepPath};
pub use self::config::{mib, CacheConfig, KeepPath};
pub use self::error::CacheError;
Loading