Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: async spi write returns before tx finishing #34

Merged
merged 3 commits into from
Sep 28, 2024
Merged

Fix: async spi write returns before tx finishing #34

merged 3 commits into from
Sep 28, 2024

Conversation

andelf
Copy link
Collaborator

@andelf andelf commented Sep 28, 2024 •
edited
Loading

Resolved by adding busy-loop waiting.

Note that the SPI end(finish) interrupt is not working in DMA mode.(only for non-DMA transfer)

Additional changes:

  • reorder Irq parameter in async fn(always comes after pins)
  • fix spi tx/rx with empty buffer

@andelf
refactor(uart): refine fn arg order
7864875 
- Irqs always come after pins
@andelf
wip(spi): add async irq done wait
1426f81 
- Not working, it seems SPI finish irq is never triggered under DMA mode
@andelf
fix(spi): add busy loop waiting for tx finish
a6e2dfc 
See-also #33
@andelf andelf merged commit 32fb3bd into master Sep 28, 2024
1 check passed
@andelf andelf deleted the fix/async-spi-unfinished-transfer branch September 28, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andelf