Add defensive checks for cases where maxHeight is empty string #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getComputedStyle().maxHeight returns an empty string (which can happen during DOM transitions, animations, or certain CSS edge cases), the existing check `maxHeightStyle !== 'none'` passes, but the subsequent call to estimateElementHeight() fails its assertion because empty string is falsy. Add a truthiness check to prevent calling estimateElementHeight() with an empty or falsy maxHeight value. Fixes assertion: "You called estimateElementHeight without a fallbackHeight"
… You called estimateElement height without a fallbackHeight
at assert$1 (assert.js:40:13)
at estimateElementHeight (estimate-element-height.js:3:3)
at StaticRadar._updateConstants (radar.js:340:36)
at StaticRadar.update (radar.js:222:10)
at radar.js:214:12
at Array.execJob (index.js:30:7)
at Scheduler.flush (index.js:92:11)
at index.js:78:12
at sentryWrapped (helpers.js:117:17)
johanrd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getComputedStyle().maxHeight returns an empty string (which can
happen during DOM transitions, animations, or certain CSS edge cases),
the existing check
maxHeightStyle !== 'none'passes, but thesubsequent call to estimateElementHeight() fails its assertion because
empty string is falsy.
Add a truthiness check to prevent calling estimateElementHeight() with
an empty or falsy maxHeight value.
Fixes assertion: "You called estimateElementHeight without a fallbackHeight", even when
estimateHeightwas set: