Skip to content

Add defensive checks for cases where maxHeight is empty string #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add defensive checks for cases where maxHeight is empty string #482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f77f17f
Fix assertion error when maxHeight is empty string
johanrd Oct 10, 2025
3680e9c
fix: add defensive check for error: Uncaught Error: Assertion Failed:…
johanrd Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vertical-collection/addon/-private/data-view/radar/radar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ export default class Radar {
const maxHeightStyle =
window.getComputedStyle(_scrollContainer).maxHeight;

if (maxHeightStyle !== 'none') {
if (maxHeightStyle && maxHeightStyle !== 'none') {
scrollContainerMaxHeight = estimateElementHeight(
_scrollContainer.parentElement,
maxHeightStyle,
Expand All @@ -419,7 +419,7 @@ export default class Radar {
}

const calculatedEstimateHeight =
typeof estimateHeight === 'string'
typeof estimateHeight === 'string' && estimateHeight
? estimateElementHeight(_itemContainer, estimateHeight)
: estimateHeight;

Expand Down