Fix 'aborted' detection on Node v15.5.0+ #1559

Jimbly · 2021-12-08T18:10:24Z

This fixes a major memory leak I encountered usign this on Node v16.
Doing a binary search of node versions, the problem appears to originate in v15.5.0 as a result of nodejs/node#33035, however later changes have quietly completely removed the 'aborted' event that http-proxy relies on, and later added a deprecation note about it (which seems to actually be incorrect).
Despite what the notes about DEP0156 say, the only way I could get this module working reliably again was to replace req.on('aborted') with instead checking res.on('close') and looking at res.writeableFinished.

For a very easy test, load any video file over the proxy, and seek backwards in Chrome. For example, run the following:

const httpProxy = require('http-proxy');

httpProxy.createProxyServer({
  target: 'http://files.dashingstrike.com.s3.amazonaws.com',
  changeOrigin: true,
}).listen(8080);

And then open http://localhost:8080/SplodyGameplayLong.mp4, and then seek backwards in the file. Chrome will abort hundreds of requests (each of which is requesting ~32MB), which, if not properly aborted, will leak connections as well as hundreds of MBs of TCP kernel memory per second (quickly bricking your instance, making it unreachable even by SSH, as I found out -_-). On Linux, you can view TCP kernel memory used with cat /proc/net/sockstat (mem is count of 4K pages), or ss -atn state big if you have ss installed.

RemiBou · 2022-07-05T12:35:40Z

Hi @Jimbly any plan to merge this ?

Jimbly · 2022-07-05T12:59:08Z

Hi @Jimbly any plan to merge this ?

I'm not the one who can merge to this repository, that would be a question for the maintainers of node-http-proxy.

Since there was no response here (abandoned project?) I had to publish my fork for some other projects though, and you can use that in the meantime: http-proxy-node16

RemiBou · 2022-07-05T14:56:47Z

Thanks I'll checkit out ! Great work :) Le mar. 5 juil. 2022 à 14:59, Jimb Esser ***@***.***> a écrit :

…

Hi @Jimbly <https://github.com/Jimbly> any plan to merge this ? I'm not the one who can merge to this repository, that would be a question for the maintainers of node-http-proxy. Since there was no response here (abandoned project?) I had to publish my fork for some other projects though, and you can use that in the meantime: http-proxy-node16 <https://www.npmjs.com/package/http-proxy-node16> — Reply to this email directly, view it on GitHub <#1559 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKLY6QUK4NAC42H5KKLTKDVSQWSRANCNFSM5JUOB7TQ> . You are receiving this because you commented.Message ID: ***@***.***>

craftzdog · 2023-01-24T12:23:15Z

This patch worked! Thanks for the fix

likev · 2023-02-23T07:51:11Z

The response 'close' event and the 'destroy' method are the correct alternatives
#1580

anthonyalayo · 2023-04-10T18:02:29Z

Is the maintainer gone?

Jimbly · 2023-04-10T19:19:37Z

No maintainers as far as I can tell. I've (just now) pushed an update to http-proxy-node16 so that it correctly links back to my fork instead of this repo, if anyone wants to redirect PRs to that repository, I can potentially merge them and update my fork (with the caveat that I don't really know any of the internals here ^_^).

cassepipe · 2023-04-17T10:03:14Z

Does this affect all versions above 16 or just 16 ?

Is this why I have a

{"statusCode":403,"message":"sse already opened","error":"Forbidden"}

... when using vite ?

Jimbly · 2023-04-17T14:15:59Z

This affects all versions 16 and above, it's due to a low-level, non-backwards-compatible change in Node. No idea if it would have anything to do with that SSE error, though you can try swapping out for http-proxy-node16 and see if it fixes it, it should be otherwise the same package.

cassepipe · 2023-04-17T15:36:21Z

This seems like a no-brainer to merge this. Is there any issues with it @indexzero @jsmylnycky ?

You could either merge this one which is apparently backwards compatible with older versions of node or this drop backwards compatibility with this shorter one #1580.

Then you can kill two merge request with one stone and close whichever you don't merge.

callumgare · 2023-05-12T01:22:21Z

lib/http-proxy/passes/web-incoming.js

@@ -18,6 +18,11 @@ var nativeAgents = { http: httpNative, https: httpsNative };
 * flexible.
 */

+// 'aborted' event stopped working reliably on v15.5.0 and was later removed entirely
+var hasAborted = (function () {


Super minor suggestion but when I first glanced at this based on the name I presumed it was a function for checking if a connection had been aborted. So maybe something like "supportsAbortedEvent" might be a bit of a clearer name?

Sounds good, changed!

The external resources proxy uses the http-proxy-middleware library to mange the proxing of requests. That in turn uses the node-http-proxy library which unfortunately has not been updated in a while and has a bug which results in sockets not being closed properly. This commit fixes that by swapping that library out with a patched version found here http-party/node-http-proxy#1559

This fixes a major memory leak I encountered usign this on Node v16. Doing a binary search of node versions, the problem appears to originate in v15.5.0 as a result of nodejs/node#33035, however later changes have quietly completely removed the 'aborted' event that `http-proxy` relies on, and later added a deprecation note about it (which seems to actually be incorrect). Despite what the notes about [DEP0156](https://nodejs.org/dist/latest-v16.x/docs/api/deprecations.html#DEP0156) say, the only way I could get this module working reliably again was to replace `req.on('aborted')` with instead checking `res.on('close')` and looking at `res.writeableFinished`.

The external resources proxy uses the http-proxy-middleware library to mange the proxing of requests. That in turn uses the node-http-proxy library which unfortunately has not been updated in a while and has a bug which results in sockets not being closed properly. This commit fixes that by swapping that library out with a patched version found here http-party/node-http-proxy#1559

pickeloe5 · 2023-11-26T17:10:46Z

My website was crashing while I was advertising it which made me very upset.

This P.R. fixes the crash, thank you very much Jimbly.

ravin00 · 2024-10-29T21:18:59Z

lib/http-proxy/passes/web-incoming.js

@@ -18,6 +18,11 @@ var nativeAgents = { http: httpNative, https: httpsNative };
 * flexible.
 */

+// 'aborted' event stopped working reliably on v15.5.0 and was later removed entirely


var supportsAbortedEvent = (function () { var [major, minor] = process.versions.node.split('.').map(Number); return major < 15 || (major === 15 && minor < 5); }());

i think this will be more suitable

ravin00 · 2024-10-29T21:21:17Z

lib/http-proxy/passes/web-incoming.js

-    req.on('aborted', function () {
-      proxyReq.abort();
-    });
+    if (supportsAbortedEvent) {


if (supportsAbortedEvent) { req.on('aborted', () => proxyReq.abort()); } else { res.on('close', () => { if (!res.writableFinished) proxyReq.abort(); }); }
This would be suitable too i think

Jimbly mentioned this pull request Dec 8, 2021

http.IncomingMessage 'aborted' issues nodejs/node#41117

Closed

Jimbly mentioned this pull request Jul 5, 2022

Possible connection leakage #1582

Open

Jimbly mentioned this pull request Sep 13, 2022

Updated Version of follow-redirects from 1.0.0 to 1.14.8 #1608

Closed

loren138 mentioned this pull request Nov 9, 2022

Memory leak when client closes connection prematurely #1586

Open

lbeschastny added a commit to lbeschastny/http-proxy-memory-leak-example that referenced this pull request Nov 10, 2022

Update http-proxy version to http-party/node-http-proxy#1559

b9bb845

lbeschastny mentioned this pull request Nov 10, 2022

Memory leak in http-proxy dependency when client closes connection prematurely chimurai/http-proxy-middleware#782

Open

2 tasks

simhnna mentioned this pull request Feb 15, 2023

Detecting client request aborts in nodejs >= 15.50 is broken nodejs/node#46666

Open

callumgare mentioned this pull request May 12, 2023

fix request abort for node 16+ #1580

Open

callumgare reviewed May 12, 2023

View reviewed changes

Jimbly force-pushed the master branch from ba0c414 to 058182a Compare May 12, 2023 13:02

This was referenced Sep 1, 2023

Triage from upstream issues and PRs unjs/httpxy#2

Open

fix: handle client close event unjs/httpxy#8

Merged

consideRatio mentioned this pull request Feb 2, 2024

Socket leak jupyterhub/configurable-http-proxy#434

Open

shaneknapp mentioned this pull request Feb 2, 2024

[DH-3] try using a test fork of the chp berkeley-dsep-infra/datahub#5501

Merged

ravin00 suggested changes Oct 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix 'aborted' detection on Node v15.5.0+ #1559

Fix 'aborted' detection on Node v15.5.0+ #1559

Jimbly commented Dec 8, 2021

RemiBou commented Jul 5, 2022

Jimbly commented Jul 5, 2022

RemiBou commented Jul 5, 2022 via email

craftzdog commented Jan 24, 2023

likev commented Feb 23, 2023

anthonyalayo commented Apr 10, 2023

Jimbly commented Apr 10, 2023

cassepipe commented Apr 17, 2023 •

edited

Loading

Jimbly commented Apr 17, 2023

cassepipe commented Apr 17, 2023 •

edited

Loading

callumgare May 12, 2023 •

edited

Loading

Jimbly May 12, 2023

pickeloe5 commented Nov 26, 2023

ravin00 Oct 29, 2024

ravin00 Oct 29, 2024

Fix 'aborted' detection on Node v15.5.0+ #1559

Are you sure you want to change the base?

Fix 'aborted' detection on Node v15.5.0+ #1559

Conversation

Jimbly commented Dec 8, 2021

RemiBou commented Jul 5, 2022

Jimbly commented Jul 5, 2022

RemiBou commented Jul 5, 2022 via email

craftzdog commented Jan 24, 2023

likev commented Feb 23, 2023

anthonyalayo commented Apr 10, 2023

Jimbly commented Apr 10, 2023

cassepipe commented Apr 17, 2023 • edited Loading

Jimbly commented Apr 17, 2023

cassepipe commented Apr 17, 2023 • edited Loading

callumgare May 12, 2023 • edited Loading

Choose a reason for hiding this comment

Jimbly May 12, 2023

Choose a reason for hiding this comment

pickeloe5 commented Nov 26, 2023

ravin00 Oct 29, 2024

Choose a reason for hiding this comment

ravin00 Oct 29, 2024

Choose a reason for hiding this comment

cassepipe commented Apr 17, 2023 •

edited

Loading

cassepipe commented Apr 17, 2023 •

edited

Loading

callumgare May 12, 2023 •

edited

Loading