use husarion_components_description #577
Conversation
WalkthroughReferences to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ROS_Launch
participant husarion_components_description
participant URDF_Xacro
User->>ROS_Launch: Launch simulation (simulate_robot.launch.py)
ROS_Launch->>husarion_components_description: Include gz_components.launch.py
ROS_Launch->>URDF_Xacro: Load URDF (includes husarion_components_description xacro)
URDF_Xacro->>husarion_components_description: Use components macros
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
husarion_ugv/hardware_deps.repos(1 hunks)husarion_ugv/simulation_deps.repos(1 hunks)husarion_ugv_description/package.xml(1 hunks)husarion_ugv_description/urdf/lynx.urdf.xacro(1 hunks)husarion_ugv_description/urdf/panther.urdf.xacro(1 hunks)husarion_ugv_gazebo/CONFIGURATION.md(1 hunks)husarion_ugv_gazebo/launch/simulate_robot.launch.py(1 hunks)husarion_ugv_gazebo/package.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Run unit tests hardware build type
- GitHub Check: Run unit tests simulation build type
🔇 Additional comments (7)
husarion_ugv_gazebo/CONFIGURATION.md (1)
11-11: Link updated to new repository name
The URL for the ANT02 component now correctly points tohusarion_components_description.husarion_ugv_description/urdf/panther.urdf.xacro (1)
29-31: Update package include path
The<xacro:include>now referenceshusarion_components_descriptioninstead of the old package.husarion_ugv_gazebo/package.xml (1)
31-31: Replace runtime dependency
The exec-time dependency under the simulation condition has been updated tohusarion_components_description.husarion_ugv_description/urdf/lynx.urdf.xacro (1)
29-31: Update package include path
The<xacro:include>directive now correctly points tohusarion_components_description.husarion_ugv_gazebo/launch/simulate_robot.launch.py (1)
193-196: Correct package reference for component launch.The
FindPackageSharesubstitution is updated to"husarion_components_description", replacing the old"ros_components_description". This aligns with the renamed repository. Please confirm that the new package dependency is declared inpackage.xmland available in the workspace at the specified commit.husarion_ugv/simulation_deps.repos (1)
14-17: Update dependency entry for components description.The repository key, URL, and commit hash have been updated to
husarion_components_description(https://github.com/husarion/husarion_components_description.git@0a828de00e2ab59cfd7bc397b8af021c60d52ba5). Ensure this commit exists and that downstream consumers of this.reposfile fetch the correct version.husarion_ugv/hardware_deps.repos (1)
10-13: Align hardware deps with renamed components repo.The entry for
husarion_components_descriptionnow replacesros_components_description, with matching Git URL and version as insimulation_deps.repos. Verify consistency across all.reposfiles and that CI pipelines pull the updated repo correctly.
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin humble-devel
git worktree add -d .worktree/backport-577-to-humble-devel origin/humble-devel
cd .worktree/backport-577-to-humble-devel
git switch --create backport-577-to-humble-devel
git cherry-pick -x 6942915d378c5658b9cfeb3435f71bf24710de7d |
* use husarion_components_description * bump components version (cherry picked from commit 6942915)
Description
Requirements
.reposTests 🧪
Summary by CodeRabbit
ros_components_descriptiontohusarion_components_descriptionacross configuration, dependency, URDF, launch, and documentation files.