Added 'UNKNOWN' button for measurable habits #2109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You guys are cooking recently, awesome work! |
oshhh
reviewed
Mar 8, 2025
| val prefs = appComponent.preferences | ||
| view = CheckmarkPopupBinding.inflate(LayoutInflater.from(context)) | ||
| arrayOf(view.yesBtn, view.skipBtn).forEach { | ||
| arrayOf(view.yesBtn).forEach { |
There was a problem hiding this comment.
We don't have a yes button for number dialog right? Do we need this line at all?
I'm sorry if I am missing something basi - I am unfamiliar with this codebase - just looked up the git repo to fix this issue and saw this cl already raised. Thanks!
Collaborator
|
Hey thanks, the code looks good to me, but I haven't tested it. About this, the fact that the tests pass with this change without any adaptation of the tests is a good indication that we are missing some tests... If you're willing to go the extra mile, adding a corresponding test would be nice. |
Owner
|
Thanks for the PR, @kalina559. I have merged it with some minor changes. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #1857 and #1815 by enabling users to 'reset' an entry for a measurable habit if they added it by mistake. As this is not just a bug fix, but rather a new feature, I'll wait for an approval by @iSoron or @hiqua.