Skip to content

Conversation

@wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Aug 22, 2025


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.

if len(self._allRelPairs) > 0:
self._relationGeneral = pd.DataFrame(self._allRelPairs, columns=self._relationNames)
if self._screen:
print(self._relationGeneral)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use the logger?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to logging

@wangcj05 wangcj05 mentioned this pull request Sep 25, 2025
7 tasks
@wangcj05 wangcj05 changed the base branch from wangc/architecture to main September 25, 2025 21:15
@mandd
Copy link
Collaborator

mandd commented Sep 25, 2025

Tests are green. PR is good to me. Thanks!

@mandd mandd merged commit d4f4864 into main Sep 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants