Skip to content

Conversation

@MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Nov 4, 2025

Pull Request Checklist for MontePy

Description

This is a quick "bug fix" for not being able to parse FMESH. This just doesn't parse fmesh and punts the final solution to #11.

Fixes #846


General Checklist

  • I have performed a self-review of my own code.
  • The code follows the standards outlined in the development documentation.
  • I have formatted my code with black version 25.
  • I have added tests that prove my fix is effective or that my feature works (if applicable).

LLM Disclosure

Were any large language models (LLM or "AI") used in to generate any of this code?

  • Yes
    • Model(s) used:
  • No

Documentation Checklist

  • I have documented all added classes and methods.
  • For infrastructure updates, I have updated the developer's guide.
  • For significant new features, I have added a section to the getting started guide.

First-Time Contributor Checklist

  • If this is your first contribution, add yourself to pyproject.toml if you wish to do so.

Additional Notes for Reviewers

Ensure that:

  • This PR fully addresses and resolves the referenced issue(s).
  • The submitted code is consistent with the merge checklist outlined here.
  • The PR covers all relevant aspects according to the development guidelines.
  • 100% coverage of the patch is achieved, or justification for a variance is given.

📚 Documentation preview 📚: https://montepy--850.org.readthedocs.build/en/850/

@MicahGale MicahGale added bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". parsers are hard Examples of where MCNP syntax is complicated and should be simplified. labels Nov 4, 2025
@MicahGale MicahGale self-assigned this Nov 4, 2025
@MicahGale MicahGale requested a review from tjlaboss November 4, 2025 15:11
@MicahGale MicahGale marked this pull request as ready for review November 4, 2025 15:11
@MicahGale MicahGale mentioned this pull request Nov 4, 2025
@MicahGale
Copy link
Collaborator Author

Could you review this one first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". parsers are hard Examples of where MCNP syntax is complicated and should be simplified.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commas not allowed in mesh tally arguments

2 participants