Skip to content

Temporarily fixed parsing error with FMESH #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Temporarily fixed parsing error with FMESH #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f4ea13
Made test to replicate #846.
MicahGale Nov 4, 2025
fd3cec8
Banned fmesh.
MicahGale Nov 4, 2025
9a3b3cc
Added #846 to changelog.
MicahGale Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ MontePy Changelog
* Fixed bug where lines that were the allowed length was raising a ``LineOverRunWarning`` when read by MontePy (:issue:`517`).
* Added descriptive TypeError messages (:issue:`801`)
* Fixed a bug that caused to write an extra termination line between the data block and the cell data section in the MCNP input. (:pull:`819`) (:issue:`703`).
* Avoided parsing ``FMESH`` inputs that have more complicated syntax to parse (:issue:`846`).

**Documentation**

Expand Down
2 changes: 1 addition & 1 deletion montepy/data_inputs/data_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
universe_input.UniverseInput,
}

VERBOTEN = {"de", "sdef"}
VERBOTEN = {"de", "sdef", "fmesh"}


def parse_data(input: montepy.mcnp_object.InitInput):
Expand Down
7 changes: 7 additions & 0 deletions tests/test_tally.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,10 @@ def test_de_parsing_jail(_, line):
assert data.mcnp_str() == line
with pytest.raises(montepy.exceptions.UnsupportedFeature):
data.data


class TestFmesh:
# this is hacky; just makes sure it doesn't crash
@pytest.mark.parametrize("line", ["fmesh1:n vec=0 0 0", "fmesh1:n vec=0, 0, 0"])
def test_fmesh_parse(_, line):
parse_data(line)