-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Libmesh update 20250205 #29817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libmesh update 20250205 #29817
Conversation
Job Documentation, step Docs: sync website on 70fce7b wanted to post the following: View the site here This comment will be updated on new commits. |
Job Coverage, step Generate coverage on 70fce7b wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
It looks like I may need to go through some apps and fix up the PETSc macros |
|
74b318c
to
9622db6
Compare
I think that when https://github.inl.gov/ncrc/pronghorn/pull/1292 and idaholab/virtual_test_bed#520 are merged, then pronghorn devel (which currently has a subchannel module update that fixes the libmesh petsc call macros) can go to master, and then I believe we'll be all set to go for invalidating the failing app tests |
Job Documentation internal apps on 9622db6 : invalidated by @lindsayad |
Job Internal app tests on 9622db6 : invalidated by @lindsayad |
relap-7 and sockeye should be fixed now thanks to @joshuahansel. Looks like we need a rebase here |
I'll do the rebase in a sec. |
Well, I'll rebase the newsletter, anyway; simpler to just redo the other commits. |
9622db6
to
26b9557
Compare
I added the other targets. Looks like we need another rebase |
neat... you'll be one of the first to follow: https://github.com/idaholab/moose/wiki/Updating-packages |
26b9557
to
e8eb234
Compare
Anyway we can wait to get libMesh/libmesh#4091 in here? |
c1c8fab
to
70fce7b
Compare
Job Precheck, step Versioner verify on 70fce7b wanted to post the following: Versioner templatesFound 16 templates, 0 failed Versioner versionsFound 10 packages, 2 changed, 0 failed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump looks good to me! 👍
I don't understand why the openmpi tests are taking so long. Can we just merge this bad boy? |
2 crashes with stack traces in PetscInitialize, one timeout just starting a test. My vote is for "just merge this bad boy" - I could make a long list of all the things I could have theoretically broken with the dozen odd major changes in this update, but "PetscInitialize, but only with OpenMPI" would not be on it. It's disappointing to see OpenMPI so flaky, though. Way back when I used to switch between OpenMPI and MPICH frequently, well, neither of them was perfect, but OpenMPI was always the more reliable of the two. |
I would still like to remove the openmpi target, at least on PRs. The sum of time developers have spent wondering about false positives has to at least be on the order of hours at this point |
I don't think I've seen a PR test green without invalidation in months and openmpi is usually the culprit |
I like the OpenMPI target as a "sanity check" for weird MPI-looking failures in MPICH, but it really should be going yellow on failure, not red. What's the verdict for this case, though? Merge despite OpenMPI, or invalidate and cross our fingers? |
Ah, wait, never mind, we're still branch locked. |
Update libMesh submodule:
normals
vectors at the sides of edge elements in 3D, which were previously hard-coded to return(-1,0,0)
and(1,0,0)
at points 0 and 1 respectively (the correct solution only for x-axis-aligned edges), are now correctly calculated for all edges in 2D/3D. Compatibility with this fix required a corresponding fix in one MOOSE application; developers of any applications not in MOOSE CI who use non-x-axis-aligned edge elements may wish to test their codes for result changes with this update.--mpi-thread-type
to manually choose between "single", "funneled", "serialized", and "multiple" MPI initialization threading options. Initialization still defaults to "funneled" (for maximum compatibility with older MPI implementations), but users of slate/strumpack may need to specify "multiple" for compatibility with those packages.HYPRE_SetMemoryLocation
in more complicated (e.g. field split) configurationscontrib/boost
, which was a version incompatible with C++17. libMesh codes (including MOOSE) which require boost now must have an external boost installation to use.MeshTools::n_connected_components()
function to count the number of connected components in a meshPetscMatrix::frobenius_norm()
method, and refactoring of other norm calculationscalculator
appLibmeshPetscCall
for error checking../configure
source) codeFEInterface
Edit: a force push also adds:
transient_ex3
example application demonstrating a explicit DG/FV formulation of the 2D advection equation