Skip to content

Conversation

lindsayad
Copy link
Member

@lindsayad
Copy link
Member Author

If folks are good with this as-is, I'd love to slip this into idaholab/moose#29817, but if we want significant revisions then I definitely don't want this to hold that up

@moosebuild
Copy link

Job Coverage, step Generate coverage on 3f9135c wanted to post the following:

Coverage

63b299 #4091 3f9135
Total Total +/- New
Rate 63.36% 63.36% -0.00% 40.00%
Hits 74049 74049 - 6
Misses 42816 42822 +6 9

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 40.00% is less than the suggested 90.0%

This comment will be updated on new commits.

Copy link
Member

@roystgnr roystgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point I need to go through all the git grep on_command_line output and fix everything else that has a command line interface but no C++ interface...

@jwpeterson
Copy link
Member

Should we wait until CIVET is closer to 100% before merging stuff?

@moosebuild
Copy link

Job Min clang on 3f9135c : invalidated by @lindsayad

@lindsayad lindsayad merged commit 7bb20da into libMesh:devel Feb 26, 2025
19 of 20 checks passed
@lindsayad
Copy link
Member Author

We'll need to figure out what to do about that openmpi slot issue at some point for Mac arm

@roystgnr
Copy link
Member

It should be as simple as telling openmpi's mpirun to --oversubscribe, shouldn't it?

@lindsayad
Copy link
Member Author

Tossed up idaholab/moose#29966

@roystgnr
Copy link
Member

I'd love to slip this into idaholab/moose#29817

I'll wait until that's done and merged, then, before we merge #4076 and #4077, just in case we need any fixes to go in first. Those are big enough and the submodule update delayed enough that I don't want to get them into it by accident lest something cause further delay.

@lindsayad lindsayad deleted the name-prefixing branch February 27, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants