Changes several tests so that they still pass with new libmesh feature #30291
Conversation
- New libmesh feature throws and error when making a nodeset from a sideset if a nodeset with same ID exists - named_entities meshes were changes to avoid this - BoundaryInfo function now called in AdvancedExtruderGenerator that tells which sidesets should be excluded from this check closes idaholab#30085
DanielYankura
requested review from
GiudGiud,
lindsayad and
roystgnr
as code owners
|
So @roystgnr recommended that I try to make my upgrade path a bit smoother. So I updated this PR so that it just updates the boundary IDs for two meshes and comments out one test that would otherwise fail once the associated libmesh PR is merged. That way after that PR is merge no tests should be failing and I can open another PR for MOOSE that uncomments out that one test and adds the function call needed to AdvancedExtruderGenerator.C. |
|
Let’s not commit the back and forth to the repo |
DanielYankura
force-pushed
the
overwriting_existing_nodeset
branch
from
acd07f9 to
cad658b
Compare
|
Just squashed my last two commits! |
- removed call to add_equivalent_sideset from AdvancedExtruderGenerator.C - added skip to corresponding extruder boudary swap test - Two named_entities mesh files left the same
DanielYankura
force-pushed
the
overwriting_existing_nodeset
branch
from
cad658b to
4e20226
Compare
|
Just squashed that in as well! |
|
Job Documentation, step Docs: sync website on 4e20226 wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage, step Generate coverage on 4e20226 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
3 participants
Reason
Design
Impact
Must be merged before libMesh/libmesh#4121
refs #30085