Skip to content

MFEM Non-linear support #31776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 35 commits into
base: next
Choose a base branch
from
Draft

MFEM Non-linear support #31776

wants to merge 35 commits into from
+3,090 −31

Conversation

@karthichockalingam
Copy link
Contributor

@karthichockalingam karthichockalingam commented Oct 23, 2025

The PR closes #31772

Thanks,
@alexanderianblair
@SohailSTFC
@nmnobre
Karthik.

@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from f85429d to 827832a Compare October 23, 2025 19:10
moosebuild
moosebuild reviewed Oct 23, 2025
View reviewed changes
large_media Outdated
@@ -1 +1 @@
Subproject commit 7a7e52d8ffbb7223b46768ff88885c8c52f71855
Subproject commit 446b9469d717a8ed6b6235df87c4b837dc9f3a98
Copy link
Contributor

@moosebuild moosebuild Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from 827832a to 02e75a0 Compare October 23, 2025 19:43
moosebuild
moosebuild reviewed Oct 23, 2025
View reviewed changes
large_media Outdated
@@ -1 +1 @@
Subproject commit 7a7e52d8ffbb7223b46768ff88885c8c52f71855
Subproject commit 446b9469d717a8ed6b6235df87c4b837dc9f3a98
Copy link
Contributor

@moosebuild moosebuild Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from 02e75a0 to 1a1e2e6 Compare October 23, 2025 20:15
moosebuild
moosebuild reviewed Oct 23, 2025
View reviewed changes
large_media Outdated
@@ -1 +1 @@
Subproject commit 7a7e52d8ffbb7223b46768ff88885c8c52f71855
Subproject commit 446b9469d717a8ed6b6235df87c4b837dc9f3a98
Copy link
Contributor

@moosebuild moosebuild Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from 1a1e2e6 to 4a57b73 Compare October 23, 2025 21:00
moosebuild
moosebuild reviewed Oct 23, 2025
View reviewed changes
large_media Outdated
@@ -1 +1 @@
Subproject commit 7a7e52d8ffbb7223b46768ff88885c8c52f71855
Subproject commit 446b9469d717a8ed6b6235df87c4b837dc9f3a98
Copy link
Contributor

@moosebuild moosebuild Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

@moosebuild
Copy link
Contributor

moosebuild commented Oct 23, 2025 •
edited
Loading

Job Documentation, step Docs: sync website on 7be1a1a wanted to post the following:

View the site here

This comment will be updated on new commits.

@nmnobre nmnobre force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from 4a57b73 to d882727 Compare October 27, 2025 13:03
moosebuild
moosebuild reviewed Oct 27, 2025
View reviewed changes
large_media Outdated
@@ -1 +1 @@
Subproject commit 7a7e52d8ffbb7223b46768ff88885c8c52f71855
Subproject commit 446b9469d717a8ed6b6235df87c4b837dc9f3a98
Copy link
Contributor

@moosebuild moosebuild Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

moosebuild
moosebuild reviewed Oct 28, 2025
View reviewed changes
large_media Outdated
@@ -1 +1 @@
Subproject commit 7a7e52d8ffbb7223b46768ff88885c8c52f71855
Subproject commit 446b9469d717a8ed6b6235df87c4b837dc9f3a98
Copy link
Contributor

@moosebuild moosebuild Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from 1280a9a to 37726d5 Compare October 28, 2025 11:05
moosebuild
moosebuild reviewed Oct 28, 2025
View reviewed changes
large_media Outdated
@@ -1 +1 @@
Subproject commit 7a7e52d8ffbb7223b46768ff88885c8c52f71855
Subproject commit 446b9469d717a8ed6b6235df87c4b837dc9f3a98
Copy link
Contributor

@moosebuild moosebuild Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch 2 times, most recently from 6588ac0 to 62752f9 Compare October 28, 2025 19:30
@karthichockalingam
Make changes to EquationSystem and ProblemOperator to introduce non-l…
70daa19 
…inear solve
@karthichockalingam
Update jacobian in Mult
f3e0ff3
@karthichockalingam
Having one mult for EquationSystem and TimeDependentEquationSystem
1c7a288
@karthichockalingam
Use zero_vec instead of _true_rhs in problem operator
e8b4f7d
@karthichockalingam
Compute residual using linearform
7e9af0a
@karthichockalingam
Incorporate non-linear solve in EquationSystem::Mult
e086613
@karthichockalingam
Example input file to test NL solve using MFEMDomainLFGradKernel
60b2bc2
@karthichockalingam
Separate nonlinearactions from linearforms
f461ecd
@karthichockalingam
Add DomainLFGradKernel
f0d91cb
@karthichockalingam
(1) Added aux vector for b contribution (2) Dropped bilinear contribu…
8c10b5d 
…tion from MFEMDomainLFGradKernel (3) Changed input file to have only source term with homogenouse bcs for a linear problem
@karthichockalingam
Add MixedScalarWeakDivergenceKernel
5f150e9
@karthichockalingam
Add input file for non-linear problem but not working
774d310
@karthichockalingam
Fix the sign on b
754732d
@karthichockalingam
Bug fix: Changed to use sol instead of _trueBlockSol in _jacobian->Ad…
f54919a 
…dMult
@karthichockalingam
Dropped ApplyEssVals
ca5e7ea
@karthichockalingam
Take initial condition as initial guess
05bdb3c
@karthichockalingam
Add newton paramaters from executioner block
497e263
@karthichockalingam
Change to the inputfile and square.e from mesh
b170a80
@karthichockalingam
remove nldiffusion.i
d13cd2e
@karthichockalingam
Rename file from true_nldiffusion.i to nldiffusion.i
f030cdc
@karthichockalingam
change output folder name
ffe8715
@karthichockalingam
Add test for non-linear diffusion
0dbf875
@karthichockalingam
Fixed typo in MFEMDomainLFGradKernel
9b08fa1
@karthichockalingam
Add documentation to kernels and functions
69b09be
@karthichockalingam
Clang formatted idaholab#31772
12e20b3
@karthichockalingam
Change default non-linear iteration to one
3784f26
@karthichockalingam
Fix for linear and non-linear problems idaholab#31772
1c52ce1 
Warning: Increased time on CurlCurlLor
@karthichockalingam
Use local gridfunctions in UpdateEssDerivativeVals
60f3881
@karthichockalingam
Remove CopyVec
ea95fb0
@karthichockalingam
Accepted changes from mixed transient in TimeDependentEquationSystem:…
e9bd16b 
…:FormSystem
@karthichockalingam
Debug prints in EquationSystem
02b3578
@karthichockalingam
Commented call to UpdateEssDerivativeVals and debug prints in TimeDom…
23aaf58 
…ainEquationSystemProblemOperator
@karthichockalingam
Drop changes to initial guess in ../framework/src/mfem/problem_operat…
2b9f0ac 
…ors/TimeDomainEquationSystemProblemOperator.C
@karthichockalingam
Changes in EquationSystem: (1) drop update to dTdt bc (2) drop debugg…
9ccd0f1 
… prints (3) Fix bug in EquationSystem::AssembleJacobian
@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from b6a1b25 to f75f0a5 Compare November 13, 2025 15:56
@moosebuild
Copy link
Contributor

moosebuild commented Nov 13, 2025

Job Precheck, step Clang format on f75f0a5 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/31776/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format b79a48d659f36efef4240a0fa85dd5bd76ac8927

@karthichockalingam karthichockalingam force-pushed the ab_sr_kc/nl-eq-system-diffusion branch from f75f0a5 to 7be1a1a Compare November 13, 2025 16:17
@moosebuild
Copy link
Contributor

moosebuild commented Nov 13, 2025

Job Test, step Results summary on 7be1a1a wanted to post the following:

Framework test summary

Compared against b79a48d in job civet.inl.gov/job/3380566.

Added tests

Test Time (s)
mfem/kernels.MFEMNonLinearDiffusion 8.05

Run time changes

Test Base (s) Head (s) +/-
mfem/lor.MFEMCurlCurlLOR 9.55 14.34 +50.07%

Modules test summary

Compared against b79a48d in job civet.inl.gov/job/3380566.

No change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moosebuild moosebuild moosebuild left review comments

@lindsayad lindsayad Awaiting requested review from lindsayad lindsayad will be requested when the pull request is marked ready for review lindsayad is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@lindsayad lindsayad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MFEM Non-linear Solve

4 participants

@karthichockalingam @moosebuild @lindsayad @alexanderianblair