Avoided dangerous function control in THM #31882
Open
+562
−538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Job Documentation, step Docs: sync website on 51196d8 wanted to post the following: View the site here This comment will be updated on new commits. |
Re-golded Brayton cycle due to avoiding the bug that changed the results. Refs idaholab#31869
joshuahansel
force-pushed
the
control-logic-bug
branch
from
5085cf2 to
51196d8
Compare
Contributor
|
Job Test, step Results summary on 51196d8 wanted to post the following: Framework test summaryCompared against b79a48d in job civet.inl.gov/job/3380566. No change Modules test summaryCompared against b79a48d in job civet.inl.gov/job/3380566. Removed tests
Added tests
|
Contributor
|
Job Coverage, step Generate coverage on 51196d8 wanted to post the following: Framework coverageCoverage did not change Modules coverageThermal hydraulics
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
GiudGiud
reviewed
Nov 14, 2025
| 2.7,0.79,1,-0.6299675624877,0.0054927769659023,-48466.07852325,-2.5381090790405,-0.025189824726665,100352.57277976,-0.13217142069536,-0.19220314069304,0,0,156932.7622624,157039.8699799,156937.44282842,157035.61445849,1.0000298252956,1.0000270990847,100.75929890666,0.843,1,-0.50832887008028,0.0096263818861559,100.75929890666 | ||
| 2.8,0.79,1,-0.65242997905499,0.0054461335021972,-60203.333588319,-2.5380811922856,-0.025189686343251,103703.59791786,-0.13899481065159,-0.19332795306449,0,0,158650.29735246,158777.21797293,158656.14899829,158772.84211269,1.000036883926,1.0000275605083,100.75874537301,0.843,1,-0.50493471022438,0.0096416629785171,100.75874537301 | ||
| 2.9,0.79,1,-0.68397651360453,0.0054405807824613,-73894.15728764,-2.5380507462677,-0.02518953525905,107220.25934526,-0.14768423707931,-0.19383029938644,0,0,160029.31404374,160177.16128108,160036.48469731,160172.76202372,1.0000448083754,1.0000274657021,100.7581410362,0.843,1,-0.50103139119596,0.0096624138616814,100.7581410362 | ||
| 3,0.79,1,-0.72122514878988,0.0054555724256439,-88851.000217489,-2.5380194474295,-0.0251893799419,110789.65701139,-0.1572841239466,-0.19365552867233,0,0,161019.71289729,161185.80298299,161027.90621529,161181.51513083,1.0000508839437,1.0000266026297,100.7575197676,0.843,1,-0.49665602377643,0.00968798880176,100.7575197676 |
Contributor
There was a problem hiding this comment.
ompressor:rel_corrected_flow went up by a factor of 10, is that expected?
| 2.7,0.79,1,-1.1256509573291,0.0056004713272073,-2.5715478253105,-0.025355215564606,108048.58519375,-0.15416603213219,-0.15165050291098,0,0,99965.400279447,100026.29201159,99958.673484073,100021.63007083,0.99993270876368,1.0000466093259,101.42086225842,0.843,1,-0.60746953486332,0.010210141991154,101.42086225842 | ||
| 2.8,0.79,1,-1.0825584640936,0.0055986677450091,-2.5715195464477,-0.025355076150782,104345.39946441,-0.14826468012379,-0.14781287284737,0,0,99963.820875683,100015.97767021,99956.787887927,100012.69099334,0.99992964466851,1.0000328625981,101.42030460313,0.843,1,-0.59188942106232,0.010209883481196,101.42030460313 | ||
| 2.9,0.79,1,-1.0467416335778,0.0055982625302455,-2.5714886910776,-0.02535492403399,101003.55681107,-0.14339278557675,-0.14355249983726,0,0,99974.601330216,100030.0144474,99969.538485498,100024.98187865,0.9999493586906,1.0000503131183,101.41969613596,0.843,1,-0.57478630858141,0.010209429145523,101.41969613596 | ||
| 3,0.79,1,-1.0173758900668,0.0055984772752224,-2.5714569771426,-0.025354767683527,98012.260204698,-0.13938131648683,-0.13884540588179,0,0,99979.693783643,100035.22684139,99975.59231994,100029.60198418,0.99995897703276,1.0000562319264,101.41907073411,0.843,1,-0.55601479087009,0.010209236689777,101.41907073411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #31869
Component::makeFunctionControllableIfConstant()(will delete after apps updated)Component::makeFunctionControllableIfConstant()in components in THMVTB fix can be merged before this PR: idaholab/virtual_test_bed#707.