-
Notifications
You must be signed in to change notification settings - Fork 50
Confirm support for Python 3.14, drop 3.9 #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaeru
added a commit
that referenced
this pull request
Oct 24, 2025
khaeru
added a commit
that referenced
this pull request
Oct 27, 2025
Unique hash for this configuration changed on the branch.
khaeru
added a commit
that referenced
this pull request
Oct 27, 2025
1b0ba5b to
c631b91
Compare
khaeru
added a commit
that referenced
this pull request
Oct 27, 2025
Unique hash for this configuration changed on the branch.
khaeru
added a commit
that referenced
this pull request
Oct 27, 2025
khaeru
added a commit
that referenced
this pull request
Oct 27, 2025
- Use a test-local variable instead of caplog mechanism. - Set core.cache_path directly, instead of relying on Context aliasing. - Replace slice with a temporary, unhashable class.
khaeru
added a commit
that referenced
this pull request
Oct 27, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
=======================================
- Coverage 75.3% 74.7% -0.7%
=======================================
Files 270 270
Lines 22331 22312 -19
=======================================
- Hits 16836 16676 -160
- Misses 5495 5636 +141
🚀 New features to boost your workflow:
|
3 tasks
khaeru
added a commit
that referenced
this pull request
Oct 27, 2025
glatterf42
approved these changes
Oct 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the commit messages and the passing tests, this looks good to me :)
- Update version classifiers. - Bump requires-python to 3.10.
- Use Python 3.14: - with new(er) pstream versions, including main. - for single-version jobs. - Use Python 3.10 for oldest upstream version.
Unique hash for this configuration changed on the branch.
- Use @DataClass(kw_only=True) where indicated.
- Use a test-local variable instead of caplog mechanism. - Set core.cache_path directly, instead of relying on Context aliasing. - Replace slice with a temporary, unhashable class.
junukitashepard
pushed a commit
that referenced
this pull request
Oct 30, 2025
Unique hash for this configuration changed on the branch.
junukitashepard
pushed a commit
that referenced
this pull request
Oct 30, 2025
- Use a test-local variable instead of caplog mechanism. - Set core.cache_path directly, instead of relying on Context aliasing. - Replace slice with a temporary, unhashable class.
junukitashepard
pushed a commit
that referenced
this pull request
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.14 was released 2024-10-07. This PR is to:
ruff check --select F401,UP007,UP045 --fixor similar multiple times, plus some small manual clean-ups. See the ruff docs.UseToo many instances in the code base to do in this PR, so not included.match/caseinstead of someifstatements with multipleelifblocks.How to review
For @glatterf42:
Others notified as code owners:
PR checklist
Add or expand tests;coverage checks both ✅Add, expand, or update documentation.After approval: