Skip to content

Conversation

@glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Oct 15, 2024

As suggested by @khaeru in #880, we should drop support for the now outdated version 3.8 of Python and add support for the new 3.13. This PR does just that.

Please also see the analogous iiasa/ixmp#544, which details some issues that need to be closed upstream before we can support 3.13.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Update tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes.

@glatterf42 glatterf42 added enh New features & functionality dependencies Pull requests that update a dependency file labels Oct 15, 2024
@glatterf42 glatterf42 self-assigned this Oct 15, 2024
@codecov
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.6%. Comparing base (23388f0) to head (19d20d1).
Report is 49 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #881   +/-   ##
=====================================
  Coverage   95.5%   95.6%           
=====================================
  Files         46      46           
  Lines       4340    4335    -5     
=====================================
- Hits        4148    4147    -1     
+ Misses       192     188    -4     
Files with missing lines Coverage Δ
message_ix/__init__.py 100.0% <100.0%> (+8.3%) ⬆️
message_ix/core.py 97.7% <100.0%> (+<0.1%) ⬆️
message_ix/macro.py 96.7% <100.0%> (+<0.1%) ⬆️
message_ix/models.py 99.0% <100.0%> (+<0.1%) ⬆️
message_ix/report/__init__.py 100.0% <100.0%> (ø)
message_ix/report/operator.py 97.5% <100.0%> (+<0.1%) ⬆️
message_ix/report/pyam.py 100.0% <100.0%> (ø)
message_ix/testing/__init__.py 99.6% <100.0%> (+<0.1%) ⬆️
message_ix/tests/report/test_operator.py 100.0% <100.0%> (ø)
message_ix/tests/test_feature_duration_time.py 100.0% <100.0%> (ø)
... and 6 more

@glatterf42 glatterf42 force-pushed the enh/support-python3.13 branch from 7e9d42b to 10b9e8d Compare October 15, 2024 11:34
@khaeru khaeru force-pushed the enh/support-python3.13 branch from 10b9e8d to 84899f8 Compare November 20, 2024 11:04
@khaeru
Copy link
Member

khaeru commented Nov 20, 2024

Rebased with the completion of #544. If there are no obstacles, we can update this with parallel improvements to the others made on that branch.

@khaeru khaeru force-pushed the enh/support-python3.13 branch from 84899f8 to 9ba20da Compare November 20, 2024 11:28
khaeru added a commit that referenced this pull request Nov 20, 2024
@khaeru khaeru force-pushed the enh/support-python3.13 branch from 9ba20da to 89abcfc Compare November 20, 2024 11:39
khaeru added a commit that referenced this pull request Nov 20, 2024
@khaeru khaeru force-pushed the enh/support-python3.13 branch from 89abcfc to 78b1291 Compare November 20, 2024 12:00
@khaeru khaeru force-pushed the enh/support-python3.13 branch from 78b1291 to 19d20d1 Compare November 20, 2024 12:07
Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glatterf42 I leave this approval so that merging is un-blocked, but please let me know if we should discuss any of the later commits I added to the branch.

@glatterf42
Copy link
Member Author

Thanks for finishing this, I don't think we need to discuss any commits here :)
Happy to merge this if you are :)

@khaeru
Copy link
Member

khaeru commented Nov 20, 2024

Please do the honours 🚀

@glatterf42 glatterf42 merged commit 618e13a into main Nov 20, 2024
26 checks passed
@glatterf42 glatterf42 deleted the enh/support-python3.13 branch November 20, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enh New features & functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants