Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to allow spaces in file name/path #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jidehem
Copy link

@Jidehem Jidehem commented Jan 23, 2020

If you have spaces in file names or in path, the current implementation will fail because of awk '$1 == "D" { print $2; }' that will extract only the first part of the file path, up to the first space.
The fixes implements a way to circumvent this using sed

@spasche
Copy link
Contributor

spasche commented Jan 24, 2020

I noticed that the change introduces CR LF newlines.
It can be fixed directly with:

dos2unix jenkins2git.sh
git commit --amend --no-edit -a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants