-
Notifications
You must be signed in to change notification settings - Fork 13
Playbook support #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playbook support #70
Conversation
@drosetti Please review |
thanks for the PR. Can you provide an example of a successful run of the new APIs against a local IntelOwl instance? |
also, there are linter errors to be fixed |
@mlodic, I have solved the golangci-lint errors. |
Great!
Any documentation or tutorial is always appreciated, that's really the best benefit you can do to the community. Feel free to do that. |
@mlodic I have added an example for analyzing files with a playbook. It should give an overview on usage of rest of the functions. Please review. |
@mlodic Please review |
@mlodic Please review |
please do not tag us repetitively. Be respectful and use tags only when strictly needed. We have a life and we help here in our free time. Plus, please ask reviews by using the builtin way in Github (click and select on the top right of the PR). No need to ask it more than once. Patience. |
Apologies if I overstepped. I really appreciate the time you and others put into reviewing contributions. I'll make sure to follow the guidelines and be patient moving forward. |
Thank you for your understanding. Can you pull the changes that I have just merged from your other PR #71 here? So we can re-run the CI with those additional checks and then merge it. |
Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
91c7ba5
to
449c6a3
Compare
Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
I have updated the branch to run all the ci tests. |
great |
Description
Closes #60
Methods Added
Issues
add the related issue(s) your change tackles
Type of change
list down the type of change
Checklist
Important Rules
Please delete if the PR is for bug fixing.