Skip to content

Pre commit #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Pre commit #71

merged 3 commits into from
Feb 13, 2025

Conversation

pranjalg1331
Copy link

Description

I have set up a pre-commit using the pre-configured hooks from dnephin/pre-commit-golang.

This will require user to install pre-commit beforehand.

image

Issues

add the related issue(s) your change tackles

Type of change

list down the type of change

  • Bug fix
  • [ x] New feature (added a new endpoint or created)
  • Breaking fix (a bug fix or new feature that would cause exisiting functionality not to work as expected)

Checklist

  • [ x] if a new feature was added it passed all its (if made) test cases
  • if a bug fix was added it passed all its existing test cases

Important Rules

  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review

Please delete if the PR is for bug fixing.

Signed-off-by: pranjalg1331 <[email protected]>
@pranjalg1331
Copy link
Author

@mlodic Please review.

@mlodic
Copy link
Member

mlodic commented Feb 10, 2025

Great ty! Can you also change the configuration of the Github CI workflow? At this point, it makes sense to have checkers for all the linters that you enabled as pre-commit. Right now there is only golangci-lint-action

Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
@pranjalg1331
Copy link
Author

pranjalg1331 commented Feb 11, 2025

@mlodic I have updated the lint workflow to run checks which are included in pre-commit.
image
Here is a sample run on a pr I created on my fork branch. The link error is from an external code which should be corrected in this #70 pr

@mlodic mlodic merged commit 9daf180 into intelowlproject:develop Feb 13, 2025
3 of 4 checks passed
@mlodic
Copy link
Member

mlodic commented Feb 13, 2025

ty!

@mlodic mlodic mentioned this pull request Feb 13, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants