shared: add UTCDateTime column type #179
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
utnapischtim
commented
Dec 16, 2024
utnapischtim
commented
- with that it is possible to solve the datetime.utcnow DeprecationWarnings
This was referenced Dec 16, 2024
Closed
utnapischtim
force-pushed
the
add-utcdatetime-type
branch
from
f68b8cd to
77dae3f
Compare
* with that it is possible to solve the datetime.utcnow DeprecationWarnings
utnapischtim
force-pushed
the
add-utcdatetime-type
branch
from
77dae3f to
6e8950b
Compare
slint
reviewed
Dec 17, 2024
| def process_bind_param(self, value, dialect): | ||
| """Process value storing into database.""" | ||
| if isinstance(value, datetime): | ||
| return value.replace(tzinfo=None) |
There was a problem hiding this comment.
minor: I think here we should also check that value.tzinfo in (None, timezone.utc), and only in that case proceed. I would even go as far as raising an exception if it's not the case, since implicitly dropping the timezone info (or converting from local to UTC) is the behavior we want to avoid.
Needs to be tested in a couple of complex modules first (e.g. invenio-rdm-records), but I have a feeling that it'll also help us to catch some datetime-related bugs :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.