chore: update npm packages #146
Conversation
plugin/README.md
Outdated
| <a href="#point">Point</a> geometry object. | ||
| https://tools.ietf.org/html/rfc7946#section-3.1.2 | ||
|
|
||
| | Prop | Type | Description | | ||
| | ----------------- | --------------------------------------------- | ------------------------------------- | | ||
| | **`type`** | <code>'<a href="#point">Point</a>'</code> | Specifies the type of GeoJSON object. | | ||
| | **`coordinates`** | <code><a href="#position">Position</a></code> | | | ||
|
|
||
|
|
||
| #### Position | ||
|
|
||
| | Prop | Type | Description | | ||
| | ------------ | ------------------- | ----------- | | ||
| | **`line`** | <code>number</code> | >= 1 | | ||
| | **`column`** | <code>number</code> | >= 0 | |
There was a problem hiding this comment.
Hmm, I think this is something that has resurfaced, that was originally fixed by #89. Perhaps the script I added no longer works with these updated dependencies?
| // 1. check npm install path | ||
| const geojsonPathNpm = path.resolve('../node_modules/@types/geojson'); | ||
| if (fs.existsSync(geojsonPath)) { | ||
| if (fs.existsSync(geojsonPathNpm)) { |
There was a problem hiding this comment.
@OS-pedrogustavobilro This was the problem - just in my particular case.
I had accidentally ran npm install instead of pnpm install, so I had to two copies of @types/geojson, one in the NPM location and another in the PNPM location.
The other problem with the script (which i'm not sure is worth fixing right now), is that it will check once for either location. So in my case, before fixing the script, it was finding and removing the PNPM location, but not the NPM one.
There was a problem hiding this comment.
Ah I see, makes sense. Thanks for looking into this!
Yeah the checking only of the locations at should be fine I think, even if both are installed, only one ends up getting used. It's more about which one should be checked I guess. But anyway yeah I don't think we need to look into it now.
No description provided.