Skip to content

chore: update npm packages #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: update npm packages #146

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7851922
chore: update npm packages
ItsChaceD Nov 19, 2025
49f90b4
More package updates
theproducer Nov 25, 2025
31131fe
updating pnpm lockfile
theproducer Nov 25, 2025
f1aab74
Updating typo in docgen_updates
theproducer Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 20 additions & 45 deletions plugin/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,32 +1068,30 @@ A marker is an icon placed at a particular point on the map's surface.

#### Point

<a href="#point">Point</a> geometry object.
https://tools.ietf.org/html/rfc7946#section-3.1.2

| Prop | Type | Description |
| ----------------- | --------------------------------------------- | ------------------------------------- |
| **`type`** | <code>'<a href="#point">Point</a>'</code> | Specifies the type of GeoJSON object. |
| **`coordinates`** | <code><a href="#position">Position</a></code> | |


#### Position

| Prop | Type | Description |
| ------------ | ------------------- | ----------- |
| **`line`** | <code>number</code> | &gt;= 1 |
| **`column`** | <code>number</code> | &gt;= 0 |
| Prop | Type |
| ------- | ------------------- |
| **`x`** | <code>number</code> |
| **`y`** | <code>number</code> |


#### Polygon

<a href="#polygon">Polygon</a> geometry object.
https://tools.ietf.org/html/rfc7946#section-3.1.6
For web, all the javascript <a href="#polygon">Polygon</a> options are available as
Polygon extends google.maps.PolygonOptions.
For iOS and Android only the config options declared on <a href="#polygon">Polygon</a> are available.

| Prop | Type | Description |
| ----------------- | --------------------------------------------- | ------------------------------------- |
| **`type`** | <code>'<a href="#polygon">Polygon</a>'</code> | Specifies the type of GeoJSON object. |
| **`coordinates`** | <code>Position[][]</code> | |
| Prop | Type | Description |
| ------------------- | ----------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| **`paths`** | <code>any[] \| MVCArray&lt;any&gt;</code> | The ordered sequence of coordinates that designates a closed loop. Unlike polylines, a polygon may consist of one or more paths. As a result, the paths property may specify one or more arrays of &lt;code&gt;<a href="#latlng">LatLng</a>&lt;/code&gt; coordinates. Paths are closed automatically; do not repeat the first vertex of the path as the last vertex. Simple polygons may be defined using a single array of &lt;code&gt;<a href="#latlng">LatLng</a>&lt;/code&gt;s. More complex polygons may specify an array of arrays. Any simple arrays are converted into &lt;code&gt;&lt;a href="#MVCArray"&gt;MVCArray&lt;/a&gt;&lt;/code&gt;s. Inserting or removing &lt;code&gt;<a href="#latlng">LatLng</a>&lt;/code&gt;s from the &lt;code&gt;MVCArray&lt;/code&gt; will automatically update the polygon on the map. |
| **`strokeColor`** | <code>string</code> | The stroke color. All CSS3 colors are supported except for extended named colors. |
| **`strokeOpacity`** | <code>number</code> | The stroke opacity between 0.0 and 1.0 |
| **`strokeWeight`** | <code>number</code> | The stroke width in pixels. |
| **`fillColor`** | <code>string</code> | The fill color. All CSS3 colors are supported except for extended named colors. |
| **`fillOpacity`** | <code>number</code> | The fill opacity between 0.0 and 1.0 |
| **`geodesic`** | <code>boolean</code> | When &lt;code&gt;true&lt;/code&gt;, edges of the polygon are interpreted as geodesic and will follow the curvature of the Earth. When &lt;code&gt;false&lt;/code&gt;, edges of the polygon are rendered as straight lines in screen space. Note that the shape of a geodesic polygon may appear to change when dragged, as the dimensions are maintained relative to the surface of the earth. |
| **`clickable`** | <code>boolean</code> | Indicates whether this &lt;code&gt;<a href="#polygon">Polygon</a>&lt;/code&gt; handles mouse events. |
| **`title`** | <code>string</code> | Title, a short description of the overlay. Some overlays, such as markers, will display the title on the map. The title is also the default accessibility text. Only available on iOS. |
| **`tag`** | <code>string</code> | |


#### Circle
Expand Down Expand Up @@ -1269,32 +1267,9 @@ The callback function to be called when map events are emitted.
<code>(data: T): void</code>


#### Position

A <a href="#position">Position</a> is an array of coordinates.
https://tools.ietf.org/html/rfc7946#section-3.1.1
Array should contain between two and three elements.
The previous GeoJSON specification allowed more elements (e.g., which could be used to represent M values),
but the current specification only allows X, Y, and (optionally) Z to be defined.

Note: the type will not be narrowed down to `[number, number] | [number, number, number]` due to
marginal benefits and the large impact of breaking change.

See previous discussions on the type narrowing:
- {@link https://github.com/DefinitelyTyped/DefinitelyTyped/pull/21590|Nov 2017}
- {@link https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/67773|Dec 2023}
- {@link https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/71441| Dec 2024}

One can use a
{@link https://www.typescriptlang.org/docs/handbook/2/narrowing.html#using-type-predicates|user-defined type guard that returns a type predicate}
to determine if a position is a 2D or 3D position.

<code>number[]</code>


#### Marker

Supports markers of either either "legacy" or "advanced" types.
Supports markers of either "legacy" or "advanced" types.

<code>google.maps.<a href="#marker">Marker</a> | google.maps.marker.AdvancedMarkerElement</code>

Expand Down
4 changes: 2 additions & 2 deletions scripts/docgen_updates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ try {
function geojsonDependencyPath() {
// 1. check npm install path
const geojsonPathNpm = path.resolve('../node_modules/@types/geojson');
if (fs.existsSync(geojsonPath)) {
if (fs.existsSync(geojsonPathNpm)) {
Copy link

@theproducer theproducer Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OS-pedrogustavobilro This was the problem - just in my particular case.

I had accidentally ran npm install instead of pnpm install, so I had to two copies of @types/geojson, one in the NPM location and another in the PNPM location.

The other problem with the script (which i'm not sure is worth fixing right now), is that it will check once for either location. So in my case, before fixing the script, it was finding and removing the PNPM location, but not the NPM one.

Copy link
Contributor

@OS-pedrogustavobilro OS-pedrogustavobilro Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, makes sense. Thanks for looking into this!

Yeah the checking only of the locations at should be fine I think, even if both are installed, only one ends up getting used. It's more about which one should be checked I guess. But anyway yeah I don't think we need to look into it now.

return geojsonPathNpm;
}
// 2. check pnpm-style path
Expand All @@ -41,4 +41,4 @@ function geojsonDependencyPath() {
}
// 3. no geojson found
return '';
}
}