Use absolute imports instead of relative imports #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR systematically converts relative imports to absolute imports throughout the skrobot codebase, improving code clarity and maintainability. The changes follow Python best practices (PEP 8) which recommend absolute imports for better readability and to avoid ambiguity.
Key changes:
- Converted all relative imports (e.g.,
from .. import module) to absolute imports (e.g.,from skrobot import module) - Applied consistent import style across all affected modules
- Maintained proper import organization and removed unnecessary blank lines where appropriate
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| skrobot/viewers/_trimesh.py | Updated model import from relative to absolute |
| skrobot/viewers/_pyrender.py | Updated model and coordinates imports, improved whitespace formatting |
| skrobot/viewers/_notebook.py | Updated model import from relative to absolute |
| skrobot/urdf/transform_urdf.py | Updated modularize_urdf import from relative to absolute |
| skrobot/urdf/init.py | Converted all submodule imports to absolute paths |
| skrobot/sdf/init.py | Converted all submodule imports to absolute paths |
| skrobot/models/urdf.py | Updated RobotModel import from relative to absolute |
| skrobot/models/pr2.py | Updated urdf submodule import, removed extra blank line |
| skrobot/models/panda.py | Updated all parent module imports to absolute paths |
| skrobot/models/nextage.py | Updated all parent module imports to absolute paths |
| skrobot/models/kuka.py | Updated urdf submodule import, removed extra blank line |
| skrobot/models/fetch.py | Updated urdf submodule import, removed extra blank line |
| skrobot/interfaces/ros2/panda.py | Updated base module import from relative to absolute |
| skrobot/interfaces/ros2/init.py | Converted submodule imports to absolute paths |
| skrobot/interfaces/ros/pr2.py | Updated imports and reordered for consistency |
| skrobot/interfaces/ros/panda.py | Updated base module import from relative to absolute |
| skrobot/interfaces/ros/nextage.py | Updated base module import from relative to absolute |
| skrobot/interfaces/ros/move_base.py | Converted all relative imports to absolute, removed extra blank line |
| skrobot/interfaces/init.py | Updated ros module import from relative to absolute |
| skrobot/coordinates/init.py | Converted all submodule imports to absolute paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.