-
-
Notifications
You must be signed in to change notification settings - Fork 3
IR 2148 Material Entities for All Meshes, Improved hashing logic, Plugin Components #10209
Conversation
packages/engine/src/avatar/components/TransparencyDitheringComponent.tsx
Outdated
Show resolved
Hide resolved
…realengine/etherealengine into universal-material-entities
Fixed, needed some minor adjustments to plugin parameter handling and hashing logic. |
…realengine/etherealengine into universal-material-entities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error occurs on dev too and should be addressed in a future PR. Material drag and drop will give this error if the raycast hits something in the way. In the default scene this error is reproduced by the camera fade transition entity intersecting the ray - this does not have the material instance component, causing the error. Material drag and drop works if there's no intersection. |
@AidanCaruso thanks for explanation for the drag asset. Screencast.2024-06-18.13.09.16.mp4 |
No problem! This is odd in that I haven't seen it. It looks like one of the meshes is always selected, and the material library is designed to only show the material entities used by the currently selected entity(s) meshes. If you were to press the ESC key do the other material entities still not appear? |
okay, i understand our design for material library i m thinking maybe the ui part can be better, |
I agree, the UX definitely needs work. First thing we may want to add is a global/local toggle for clarity. For now pressing the escape key to deselect the currently selected entity shows all scene materials again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works well enough, still some bugs that can be addressed in subsequent PRs
* dev: (34 commits) ir 2253 fix project zip archiver (#10437) IR-2721: Zendesk integration (#10416) clearer delete scene argument id (#10440) fix editor tests (#10439) fix material removal errors due to missing source component (#10433) studio: ui feedback for loading a scene (#10404) fix material ParameterInput (#10429) update visibility to authoring layer (#10428) IR-2711: update default scene (#10399) clean up console log fix resources.json sorting not happening when it is regenerated fix styling for key value project settings (#10432) Added VITE_FEATHERS_STORE_KEY to Docker builds (#10426) IR 2148 Material Entities for All Meshes, Improved hashing logic, Plugin Components (#10209) Ir 2543 create prefab (#10384) feat(tooltip): make title from string to ReactNode to accept custom title (#10424) Update branch-build.yml (#10430) fix frustum culling calculation (#10418) show no results for unmatching query in hierarchy tree (#10415) Remove react-is hackfix install (#10425) ...
Summary
This allows editing and assigning materials using the ECS API to non-gltf sourced meshes, such as the primitive mesh component.
Subtasks Checklist
Breaking Changes
References
closes IR-2148, IR-2390
QA Steps