More IREEGPUAttrs.cpp cleanups #19142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjacob
force-pushed
the
decouple-create-mma-intrinsic
branch
from
ba42931
to
09beed3
Compare
bjacob
force-pushed
the
decouple-create-mma-intrinsic
branch
from
71697a4
to
88e9fa5
Compare
bjacob
changed the title
buildMmaOperation methods
kuhar
reviewed
Nov 14, 2024
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.cpp
Outdated
Show resolved
Hide resolved
raikonenfnu
reviewed
Nov 14, 2024
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Benoit Jacob <[email protected]>
bjacob
force-pushed
the
decouple-create-mma-intrinsic
branch
from
e0fd328
to
63128ef
Compare
raikonenfnu
approved these changes
Nov 14, 2024
raikonenfnu
reviewed
Nov 14, 2024
Comment on lines
+1144
to
+1145
| VectorType intrinCType = | ||
| getVectorType(builder.getContext(), intrinsic, MMAFragment::Acc); |
There was a problem hiding this comment.
Not required, but any thoughts on moving this into the createMmaOp itself?
kuhar
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things in this PR:
DataTileMMAAttr::buildMmaOperationcreates aMMAAttrjust to callbuildMmaOperationon it, to reuse that implementation. In addition to being roundabout, this required a comment explaining why we discarded the error status, asMMAAttr::buildMmaOperationis fallible but here we were already past validation and mutating IR. This PR refactors that to let both call a shared, infallible helper.