Repair the code for the Tilt Observer #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-benallegue
requested changes
Aug 21, 2024
Contributor
mehdi-benallegue
left a comment
mehdi-benallegue
left a comment
There was a problem hiding this comment.
The second commit seems to be only reformatting, is that necessary?
Comment on lines
10
to
18
| #include <Eigen/Geometry> | ||
| #include <hrpModel/ModelLoaderUtil.h> | ||
| #include <hrpModel/Link.h> | ||
| #include <hrpModel/ModelLoaderUtil.h> | ||
| #include <hrpModel/Sensor.h> | ||
| #include <hrpUtil/Eigen3d.h> | ||
|
|
||
| #include <state-observation/tools/rigid-body-kinematics.hpp> | ||
| #include <hrpsys-state-observation/TiltEstimator.h> | ||
| #include <state-observation/tools/rigid-body-kinematics.hpp> | ||
|
|
Contributor
There was a problem hiding this comment.
Why did you need to change this part? Is it an automatic formatting feature?
| // Configuration variables | ||
| "conf.default.alpha", alpha_char.c_str(), "conf.default.beta", | ||
| beta_char.c_str(), "conf.default.gamma", gamma_char.c_str(), ""}; | ||
| // </rtc-template> |
Contributor
There was a problem hiding this comment.
Please revert this modification as the new layout is less readable (maybe include guards to avoid reformatting).
Contributor
|
If it is only about tilt estimator, it is not a big deal as this code is deprecated and nobody was using it in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository was not compiling anymore after pulling state-observation. The code was repaired such that the compilation now succeeds, but the repaired code has not been tested.