Override assignBuildNumber rather than saveNextBuildNumber
#291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Oct 9, 2024
| @Override | ||
| protected synchronized void saveNextBuildNumber() { | ||
| } | ||
| @Override |
jeromepochat
approved these changes
Oct 9, 2024
centic9
approved these changes
Oct 9, 2024
…nto assignBuildNumber
1 task
|
@centic9 can you please release this? jenkinsci/bom#3912 (comment) (BTW I recommend setting up CD to make this sort of thing be less of a personal effort.) |
|
Did a release now, but I also orphaned the plugin now, hopefully someone else can take over. |
darinpope
added a commit
to darinpope/bom
that referenced
this pull request
Nov 10, 2024
basil
pushed a commit
to jenkinsci/bom
that referenced
this pull request
Nov 10, 2024
@centic9 I wonder if it wouldn't be better to rather mark the plugin as deprecated: its functionality is fully covered by the https://github.com/jenkinsci/coverage-plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids test failures due to (ab)use of EasyMock when running against jenkinsci/jenkins#9846.
I would appreciate a release after merge, to prevent problems in PCT.