Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override assignBuildNumber rather than saveNextBuildNumber #291

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Override assignBuildNumber rather than saveNextBuildNumber #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8c0af2
Override `assignBuildNumber` rather than `saveNextBuildNumber`
jglick Oct 9, 2024
d8f6b1b
Merge branch 'master' of https://github.com/jenkinsci/jacoco-plugin i…
jglick Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/test/java/hudson/plugins/jacococoveragecolumn/AbstractJaCoCoCoverageColumnTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,10 @@ public MyRun getLastSuccessfulBuild() {
}
}

@Override
protected synchronized void saveNextBuildNumber() {
}
@Override
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore WS (tabs).

public int assignBuildNumber() throws IOException {
return nextBuildNumber++;
}
};
assertTrue(abstractJaCoCoCoverageColumn.hasCoverage(mockJob));
assertEquals("66.67", abstractJaCoCoCoverageColumn.getPercent(mockJob));
Expand Down Expand Up @@ -218,8 +219,9 @@ public MyRun getLastSuccessfulBuild() {
}

@Override
protected synchronized void saveNextBuildNumber() {
}
public int assignBuildNumber() throws IOException {
return nextBuildNumber++;
}
}

private class MyJob extends Job<MyJob,MyRun> {
Expand Down
7 changes: 4 additions & 3 deletions src/test/java/hudson/plugins/jacococoveragecolumn/BranchCoverageColumnTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,10 @@ public MyRun getLastSuccessfulBuild() {
}
}

@Override
protected synchronized void saveNextBuildNumber() {
}
@Override
public int assignBuildNumber() throws IOException {
return nextBuildNumber++;
}
};
assertEquals("66.67", sut.getPercent(mockJob));

Expand Down
7 changes: 4 additions & 3 deletions src/test/java/hudson/plugins/jacococoveragecolumn/JaCoCoColumnTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,10 @@ public MyRun getLastSuccessfulBuild() {
}
}

@Override
protected synchronized void saveNextBuildNumber() {
}
@Override
public int assignBuildNumber() throws IOException {
return nextBuildNumber++;
}
};
assertTrue(jaCoCoColumn.hasCoverage(mockJob));
assertEquals("33.33", jaCoCoColumn.getPercent(mockJob));
Expand Down