[JENKINS-29582] Avoid null buildselector #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops use of ca:selectorList (removed in copyartifact-1.35.1), and adds a fallback to StatusBuildSelector in the event of a bad BuildSelector being passed from jelly (a similar fallback exists in copyartifact)
|
Build failure caused by #60 not being merged yet. |
|
After this PR is merged, how quickly can we get a release out? |
alecharp
changed the title
|
It seems that the PR is not validated by the build. I cannot find the |
|
Closing, as this is superceded by #77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copyartifact is heavily depended on for s3, including some use of internal jelly.
This changeset includes two changes - it normalises the jelly to match the style of current copyartifact, removing its custom namespace (which fixes the build selector missing from job configuration), and it adds a fallback buildselector in the event of null being passed (which is a better fallback than throwing a NPE, as is the current behaviour)