[FIXED JENKINS-32058] The selectorList is not in copyartifact anymore #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 1.36 of copyartifact, the selectorList taglib is only in s3 plugin. The problem is that I cannot upgrade the dependency to copyartifact:1.36 as it requires the core to be at 1.580.1 and will change the callable implementation of s3 plugin. This must be done but in a larger refactoring process.
|
🐝 |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
@reviewbybees done |
|
This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging. |
alecharp
changed the title
|
It does correct #63 and closes JENKINS-32058 and JENKINS-29582 |
|
Thanks for your PR, but now it looks like outdated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.36 of copyartifact, the selectorList taglib is only in s3
plugin. The problem is that I cannot upgrade the dependency to
copyartifact:1.36 as it requires the core to be at 1.580.1 and will
change the callable implementation of s3 plugin.
This must be done but in a larger refactoring process.
@reviewbybees