Transfer files - Fix repo snapshot manager error
#880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalbe4
changed the title
repo snapshot manager errorrepo snapshot manager error
4 tasks
|
Duplicate #881 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix resolves an issue with the
jf rt transfer-filescommand.The symptom of this issue is the following error message that occasionally could be seen in the log:
The key for fixing the issue, is the change made to the
findMatchingNodefunction. The issue was that thefindMatchingNodefunction could not always return the node. This is because the node may not be in the snapshot cache. It may yet to be discovered, or maybe it was discovered, but the snapshot cache didn't get a chance to get persisted yet, because of a shutdown of the command.With this fix, the
findMatchingNodefunction always fetches the node, It returns it if it's cached, and creates it and adds it to the cache if it isn't cached. As a result, theAddChildNodefunction became redundant and was left only to be used by one of tests,