Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer files - Fix repo snapshot manager error #881

Merged
merged 6 commits into from
Jul 31, 2023

Conversation

talarian1
Copy link
Contributor

@talarian1 talarian1 commented Jul 31, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This fix resolves an issue with the jf rt transfer-files command.
The symptom of this issue is the following error message that occasionally could be seen in the log:

repo snapshot manager - could not reach the representing node for path...
The key to fixing the issue is the change made to the findMatchingNode function. The issue was that the findMatchingNode function could not always return the node. This is because the node may not be in the snapshot cache. It may yet to be discovered, or maybe it was discovered, but the snapshot cache didn't get a chance to get persisted yet, because of a shutdown of the command.

With this fix, the findMatchingNode function always fetches the node, It returns it if it's cached, creates it, and adds it to the cache if it isn't cached.

@talarian1 talarian1 merged commit ef8a0fd into jfrog:dev Jul 31, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants