fix: add .copy() to np.where() calls to prevent read-only buffer errors #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The np.where() function can return read-only array views. When these arrays are modified in-place (e.g., in fvg() join_consecutive loop and swing_highs_lows() deduplication), it causes 'buffer source array is read-only' errors. This fix adds .copy() after np.where() calls for arrays that are later modified in-place: - fvg: fvg, top, bottom arrays - swing_highs_lows: swing_highs_lows array
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
np.where()function can return read-only array views. When these arrays are modified in-place (e.g., infvg()join_consecutive loop andswing_highs_lows()deduplication), it causesValueError: buffer source array is read-onlyerrors.This fix adds
.copy()afternp.where()calls for arrays that are later modified in-place:fvg(): fvg, top, bottom arraysswing_highs_lows(): swing_highs_lows arrayReproduction
This error occurs when using the library with VectorBT Pro, which provides OHLC data as read-only NumPy arrays for performance.
Test plan