Try to fix Gem.paths #564
Try to fix Gem.paths #564
Conversation
|
Ping @jlahtinen |
| @@ -16,4 +16,5 @@ module Bundler | |||
| end | |||
| end | |||
|
|
|||
| Gem.paths = ENV | |||
There was a problem hiding this comment.
while this might work, not sure this is the proper place (or actually the proper fix).
Gem.paths should have been properly adjusted, otherwise we're kind of in a mess anyway... 🤷
There was a problem hiding this comment.
You're absolutely right.
We’ve looked into this quite extensively, and honestly, we couldn’t figure out why this issue occurs in some projects but not in others — even when the dependencies and environment are nearly identical.
It would definitely be better to understand and fix the root cause instead of working around it. Unfortunately, we haven’t been able to pinpoint it. Given that monkey patches are already present in the relevant issue comments — and much of this file is already composed of other monkey patches (example here) — we’ve put together this PR to help unblock affected users.
That said, a proper fix to ensure Gem.paths is set up correctly would definitely be preferable. We'd be happy to adjust or close this PR if someone can point us in the right direction.
|
I think But I agree with @kares that this "fix" can be a wrong way to fix the "issue". |
See #539 and #537.
This fix is based on comments in the respective tickets. Since the entire file appears to be a hack or monkey patch, I’m not sure whether this is the “correct” solution. However, it works for us with JRuby 9.4, the current master of Warbler, and Bundler 2.6.3, running on Tomcat 9 under macOS and Windows.